cli icon indicating copy to clipboard operation
cli copied to clipboard

[dnm] _include directive demo in TOML

Open shauns opened this issue 1 year ago • 2 comments

shauns avatar Sep 27 '24 16:09 shauns

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-inner-loop

github-actions[bot] avatar Sep 27 '24 16:09 github-actions[bot]

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/private/common/json.d.ts
@@ -1,6 +1,5 @@
 export interface JsonMap {
     [key: string]: AnyJson;
 }
-type JsonArray = undefined[] | null[] | boolean[] | number[] | string[] | JsonMap[] | Date[];
-export type AnyJson = undefined | null | boolean | number | string | JsonMap | Date | JsonArray | JsonArray[];
-export {};
\ No newline at end of file
+export type JsonArray = undefined[] | null[] | boolean[] | number[] | string[] | JsonMap[] | Date[];
+export type AnyJson = undefined | null | boolean | number | string | JsonMap | Date | JsonArray | JsonArray[];
\ No newline at end of file

packages/cli-kit/dist/public/node/toml.d.ts
@@ -1,5 +1,7 @@
-import { JsonMap } from '../../private/common/json.js';
+import { JsonMap, AnyJson, JsonArray } from '../../private/common/json.js';
 export type JsonMapType = JsonMap;
+export type AnyJsonType = AnyJson;
+export type JsonArrayType = JsonArray;
 /**
  * Given a TOML string, it returns a JSON object.
  *

github-actions[bot] avatar Sep 30 '24 09:09 github-actions[bot]

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

github-actions[bot] avatar Oct 31 '24 03:10 github-actions[bot]