cli icon indicating copy to clipboard operation
cli copied to clipboard

Increase extension handle max length to 50

Open isaacroldan opened this issue 1 year ago • 2 comments

WHY are these changes introduced?

30 is too low and there is no real reason to have a low number here.

WHAT is this pull request doing?

Increase the handle limit to 50

How to test your changes?

  • Generate an extension with a long name, test that deploy works with a handle < 50 and doesn't with a handle > 50

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • [ ] Existing analytics will cater for this addition
  • [ ] PR includes analytics changes to measure impact

Checklist

  • [ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [ ] I've considered possible documentation changes

isaacroldan avatar Aug 12 '24 11:08 isaacroldan

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

github-actions[bot] avatar Aug 12 '24 11:08 github-actions[bot]

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟡 Statements
73.01% (+0.01% 🔼)
8390/11491
🟡 Branches
69.58% (+0.02% 🔼)
4092/5881
🟡 Functions 71.75% 2179/3037
🟡 Lines
73.36% (+0.01% 🔼)
7939/10822

Test suite run success

1889 tests passing in 857 suites.

Report generated by 🧪jest coverage report action from 78c0fa1e93ee41e043230cb9ed0d13a6e6484092

github-actions[bot] avatar Aug 12 '24 11:08 github-actions[bot]

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

github-actions[bot] avatar Sep 19 '24 03:09 github-actions[bot]