add deploy marketing activity extension logic
WHY are these changes introduced?
Addresses CLI portion of this ticket https://github.com/Shopify/marketing-automations/issues/2042
WHAT is this pull request doing?
Adds logic to migrate marketing activity extensions on deploy
How to test your changes?
- Follow instructions in this PR to import a marketing activity extension
- in CLI command prompt run:
pnpm shopify app deploy --path <path to app>
NOTE: this will fail right now until we update the validation in core
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
- [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
- [ ] Existing analytics will cater for this addition
- [ ] PR includes analytics changes to measure impact
Checklist
- [ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
- [ ] I've considered possible documentation changes
Thanks for your contribution!
Depending on what you are working on, you may want to request a review from a Shopify team:
- Themes: @shopify/advanced-edits
- UI extensions: @shopify/ui-extensions-cli
- Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
- Hydrogen: @shopify/hydrogen
- Other: @shopify/app-management
Coverage report
St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| π‘ | Statements | 72.87% (+0.14% πΌ) |
8301/11391 |
| π‘ | Branches | 69.46% (+0.06% πΌ) |
4050/5831 |
| π‘ | Functions | 71.66% (+0.07% πΌ) |
2164/3020 |
| π‘ | Lines | 73.22% (+0.15% πΌ) |
7852/10724 |
Show new covered files π£
St.:grey_question: |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| π΄ | ... / marketing_activity.ts |
25% | 100% | 0% | 25% |
| π’ | ... / marketing_activity_schema.ts |
100% | 100% | 100% | 100% |
| π’ | ... / migrate-marketing-activity-extension.ts |
100% | 87.5% | 100% | 100% |
Show files with reduced coverage π»
St.:grey_question: |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| π’ | ... / identifiers-extensions.ts |
84.91% (-3.87% π») |
73.77% (-4.41% π») |
100% | 86.32% (-3.46% π») |
| π’ | ... / common.ts |
87.5% (+6.55% πΌ) |
100% (+37.5% πΌ) |
66.67% (-4.76% π») |
86.67% (+6.67% πΌ) |
| π’ | ... / ConcurrentOutput.tsx |
98.39% (-1.61% π») |
90.91% (-4.55% π») |
100% | 98.33% (-1.67% π») |
Test suite run success
1865 tests passing in 848 suites.
Report generated by π§ͺjest coverage report action from b85dc548b7ce19a34529a9e5db0855298fdef08d
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.