cli icon indicating copy to clipboard operation
cli copied to clipboard

add deploy marketing activity extension logic

Open billycai opened this issue 1 year ago β€’ 2 comments

WHY are these changes introduced?

Addresses CLI portion of this ticket https://github.com/Shopify/marketing-automations/issues/2042

WHAT is this pull request doing?

Adds logic to migrate marketing activity extensions on deploy

How to test your changes?

  1. Follow instructions in this PR to import a marketing activity extension
  2. in CLI command prompt run: pnpm shopify app deploy --path <path to app>

NOTE: this will fail right now until we update the validation in core

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • [ ] Existing analytics will cater for this addition
  • [ ] PR includes analytics changes to measure impact

Checklist

  • [ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [ ] I've considered possible documentation changes

billycai avatar Jul 12 '24 21:07 billycai

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

github-actions[bot] avatar Jul 12 '24 21:07 github-actions[bot]

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
72.87% (+0.14% πŸ”Ό)
8301/11391
🟑 Branches
69.46% (+0.06% πŸ”Ό)
4050/5831
🟑 Functions
71.66% (+0.07% πŸ”Ό)
2164/3020
🟑 Lines
73.22% (+0.15% πŸ”Ό)
7852/10724
Show new covered files 🐣
St.:grey_question:
File Statements Branches Functions Lines
πŸ”΄
... / marketing_activity.ts
25% 100% 0% 25%
🟒
... / marketing_activity_schema.ts
100% 100% 100% 100%
🟒
... / migrate-marketing-activity-extension.ts
100% 87.5% 100% 100%
Show files with reduced coverage πŸ”»
St.:grey_question:
File Statements Branches Functions Lines
🟒
... / identifiers-extensions.ts
84.91% (-3.87% πŸ”»)
73.77% (-4.41% πŸ”»)
100%
86.32% (-3.46% πŸ”»)
🟒
... / common.ts
87.5% (+6.55% πŸ”Ό)
100% (+37.5% πŸ”Ό)
66.67% (-4.76% πŸ”»)
86.67% (+6.67% πŸ”Ό)
🟒
... / ConcurrentOutput.tsx
98.39% (-1.61% πŸ”»)
90.91% (-4.55% πŸ”»)
100%
98.33% (-1.67% πŸ”»)

Test suite run success

1865 tests passing in 848 suites.

Report generated by πŸ§ͺjest coverage report action from b85dc548b7ce19a34529a9e5db0855298fdef08d

github-actions[bot] avatar Jul 19 '24 18:07 github-actions[bot]

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

github-actions[bot] avatar Sep 11 '24 17:09 github-actions[bot]