Shopify
[DNM]
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
- [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
- [ ] Existing analytics will cater for this addition
- [ ] PR includes analytics changes to measure impact
Checklist
- [ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
- [ ] I've considered possible documentation changes
- [ ] I've made sure that any changes to
devordeployhave been reflected in the internal flowchart.
Thanks for your contribution!
Depending on what you are working on, you may want to request a review from a Shopify team:
- Themes: @shopify/advanced-edits
- UI extensions: @shopify/ui-extensions-cli
- Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
- Hydrogen: @shopify/hydrogen
- Other: @shopify/app-management
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Unused exports (1)
| Filename | exports |
|---|---|
| packages/app/src/cli/services/dev/processes/app-logs-process.ts | pollAppLogs |
Unused types (2)
| Filename | types |
|---|---|
| packages/app/src/cli/services/dev/processes/app-logs-process.ts | AppLogsQueryOptions |
| packages/app/src/cli/services/app_logs/subscribe_app_logs.ts | AppLogsQueryOptions |
Coverage report
St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 71.31% (-0.74% 🔻) |
6971/9776 |
| 🟡 | Branches | 68.55% (-0.39% 🔻) |
3426/4998 |
| 🟡 | Functions | 70.73% (-0.76% 🔻) |
1861/2631 |
| 🟡 | Lines | 72.61% (-0.76% 🔻) |
6571/9050 |
Show new covered files 🐣
St.:grey_question: |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / replay.ts |
0% | 100% | 0% | 0% |
| 🔴 | ... / fetch_app_logs.ts |
9.09% | 0% | 0% | 9.09% |
| 🔴 | ... / output.ts |
23.08% | 0% | 0% | 23.08% |
| 🔴 | ... / subscribe_app_logs.ts |
33.33% | 100% | 0% | 33.33% |
| 🔴 | ... / write_app_logs.ts |
7.69% | 100% | 0% | 7.69% |
| 🔴 | ... / app-logs-process.ts |
8.33% | 0% | 0% | 8.33% |
Show files with reduced coverage 🔻
St.:grey_question: |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / app.ts |
86.01% (-0.19% 🔻) |
73.49% (-0.62% 🔻) |
88.89% (-0.47% 🔻) |
87.3% (-0.2% 🔻) |
| 🟢 | ... / loader.ts |
93.06% (+0.03% 🔼) |
86.98% (+0.2% 🔼) |
94.79% (-0.21% 🔻) |
93.81% (-0.22% 🔻) |
| 🟢 | ... / extension-instance.ts |
84.8% (-0.91% 🔻) |
77.89% (+0.34% 🔼) |
90.48% (-0.63% 🔻) |
86.21% (-0.89% 🔻) |
| 🟢 | ... / app_config_webhook.ts |
91.3% (-8.7% 🔻) |
81.82% (-18.18% 🔻) |
100% | 90.91% (-9.09% 🔻) |
| 🟢 | ... / config.ts |
93.55% (+2.37% 🔼) |
82.35% (+7.35% 🔼) |
88.89% (-1.11% 🔻) |
96% (-0.43% 🔻) |
| 🟡 | ... / dev.ts |
68.09% (-8.11% 🔻) |
56.25% | 72.22% (-9.03% 🔻) |
62.5% (-8.93% 🔻) |
| 🟡 | ... / select-app.ts |
70.37% (-4.63% 🔻) |
66.67% (-15.69% 🔻) |
87.5% (-2.5% 🔻) |
72.73% (-5.05% 🔻) |
| 🟢 | ... / identifiers-extensions.ts |
86.25% (-2.64% 🔻) |
75% (-5.77% 🔻) |
100% | 87.5% (-2.39% 🔻) |
| 🟢 | ... / setup-dev-processes.ts |
95% (+0.13% 🔼) |
66.67% (-1.52% 🔻) |
90% | 94.29% (+0.17% 🔼) |
| 🟡 | ... / session.ts |
76.47% | 62.67% (-0.15% 🔻) |
90% | 76.72% |
| 🟢 | ... / ConcurrentOutput.tsx |
97.62% (-2.38% 🔻) |
75% (-8.33% 🔻) |
100% | 97.44% (-2.56% 🔻) |
| 🟢 | ... / spin.ts |
97.5% | 65.38% (-3.85% 🔻) |
100% | 97.44% |
Test suite run success
1637 tests passing in 763 suites.
Report generated by 🧪jest coverage report action from 2b7bee2abfddef7fe29092cc9be4da1a825cf096
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.