Shopify
payment apps: add support for supported buyer contexts
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
- [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
- [ ] Existing analytics will cater for this addition
- [ ] PR includes analytics changes to measure impact
Checklist
- [ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
- [ ] I've considered possible documentation changes
- [ ] I've made sure that any changes to
devordeployhave been reflected in the internal flowchart.
Coverage report
St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 71.96% (+0.13% 🔼) |
7034/9775 |
| 🟡 | Branches | 68.79% (-0.33% 🔻) |
3483/5063 |
| 🟡 | Functions | 71.44% (-0.03% 🔻) |
1881/2633 |
| 🟡 | Lines | 73.27% (+0.18% 🔼) |
6632/9051 |
Show new covered files 🐣
St.:grey_question: |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / shopify-developers-client.ts |
1.65% | 0% | 0% | 1.74% |
| 🟢 | ... / active-app-release.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / apps.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / create-app-version.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / create-app.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / organization.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / organizations.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / release-version.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / user-info.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / shopify-developers.ts |
100% | 75% | 100% | 100% |
Show files with reduced coverage 🔻
St.:grey_question: |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / app.test-data.ts |
93.06% (-0.04% 🔻) |
92.94% (-0.47% 🔻) |
83.56% | 92.55% (-0.05% 🔻) |
| 🟢 | ... / app.ts |
86.21% (-0.94% 🔻) |
74.12% (+1.39% 🔼) |
89.36% (-1.75% 🔻) |
87.5% (-1.21% 🔻) |
| 🟢 | ... / identifiers.ts |
100% (+4.08% 🔼) |
88.24% (-0.34% 🔻) |
100% | 100% |
| 🟢 | ... / loader.ts |
93.04% (-0.52% 🔻) |
86.78% (-0.72% 🔻) |
95% (-0.41% 🔻) |
94.03% (-0.43% 🔻) |
| 🟢 | ... / extension-instance.ts |
85.71% (-0.21% 🔻) |
77.55% (-0.88% 🔻) |
91.11% | 87.1% (-0.2% 🔻) |
| 🟢 | ... / config.ts |
91.18% (-1.68% 🔻) |
75% (-10.71% 🔻) |
90% (+1.11% 🔼) |
96.43% (+0.78% 🔼) |
| 🟢 | ... / generate.ts |
100% | 78.13% (-1.88% 🔻) |
100% | 100% |
| 🟢 | ... / write-app-configuration-file.ts |
95% (-0.12% 🔻) |
89.29% (-3.31% 🔻) |
100% | 97.3% (-0.07% 🔻) |
| 🟢 | ... / link.ts |
96.1% (-0.41% 🔻) |
72.73% (-19.21% 🔻) |
100% | 95.89% (-0.5% 🔻) |
| 🟢 | ... / breakdown-extensions.ts |
96.43% (-0.12% 🔻) |
82.69% (-0.64% 🔻) |
100% | 100% |
| 🟢 | ... / id-matching.ts |
98.77% (-0.18% 🔻) |
75% (-9.62% 🔻) |
100% | 100% |
| 🟢 | ... / select-app.ts |
92.86% (-0.48% 🔻) |
75% | 100% | 100% |
| 🟢 | ... / extension.ts |
91.21% (-0.1% 🔻) |
74.51% (+0.92% 🔼) |
91.67% | 90.91% (-0.1% 🔻) |
| 🟢 | ... / fetch-extension-specifications.ts |
95.65% (-1.01% 🔻) |
87.5% (+7.5% 🔼) |
100% | 100% |
| 🔴 | ... / developer-platform-client.ts |
40% (+3.64% 🔼) |
28.57% (-2.68% 🔻) |
50% (-10% 🔻) |
41.67% (+4.82% 🔼) |
Test suite run success
1655 tests passing in 767 suites.
Report generated by 🧪jest coverage report action from 894b551efead0a0da180c7b17b947265001ad222
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.
@punkstar something to also keep in mind is that the minimum required CLI version for payments app extension support is v3.60. Your PR changes would only be applicable to future CLI version releases (soonest being May 27th)
Thanks for the feedback @marklevi! I've added some tests around the TOML generation to cover the new field and I've top hatted the import extension command. All looks fine!