cli icon indicating copy to clipboard operation
cli copied to clipboard

Use valid redeemable_type value

Open marklevi opened this issue 1 year ago β€’ 4 comments

Use valid redeemable_type (gift-card vs gift_card) in the extension-to-toml tests

Checklist

  • [ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [ ] I've considered possible documentation changes
  • [ ] I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

marklevi avatar Apr 11 '24 15:04 marklevi

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/cli-foundations

github-actions[bot] avatar Apr 11 '24 15:04 github-actions[bot]

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

github-actions[bot] avatar Apr 11 '24 15:04 github-actions[bot]

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements 72.31% 6929/9582
🟑 Branches 69.44% 3406/4905
🟑 Functions 71.3% 1853/2599
🟑 Lines 73.51% 6530/8883

Test suite run success

1654 tests passing in 765 suites.

Report generated by πŸ§ͺjest coverage report action from aa9859bed01e41176b7734c0ad85937135a76f99

github-actions[bot] avatar Apr 11 '24 15:04 github-actions[bot]

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. β†’ If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

github-actions[bot] avatar May 12 '24 03:05 github-actions[bot]