cli icon indicating copy to clipboard operation
cli copied to clipboard

Leave out web info when there is no web

Open amcaplan opened this issue 1 year ago • 6 comments

WHY are these changes introduced?

It used to be we could always assume there's a web. That's not true anymore.

WHAT is this pull request doing?

Don't show a web if there is none.

Before:

Screenshot 2024-02-11 at 23 28 06

After:

Screenshot 2024-02-11 at 23 27 28

How to test your changes?

Run app info on an extension-only app. It should correctly omit web and spacing should look normal.

It should also still work normally on an app with a home.

Measuring impact

How do we know this change was effective? Please choose one:

  • [x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • [ ] Existing analytics will cater for this addition
  • [ ] PR includes analytics changes to measure impact

Checklist

  • [x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [x] I've considered possible documentation changes
  • [x] I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

amcaplan avatar Feb 11 '24 21:02 amcaplan

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

github-actions[bot] avatar Feb 11 '24 21:02 github-actions[bot]

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

github-actions[bot] avatar Mar 13 '24 03:03 github-actions[bot]

still relevant...

amcaplan avatar Mar 13 '24 14:03 amcaplan

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

github-actions[bot] avatar Apr 13 '24 03:04 github-actions[bot]

Still relevant! Just not highest priority at the moment

amcaplan avatar Apr 14 '24 09:04 amcaplan

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

github-actions[bot] avatar May 16 '24 03:05 github-actions[bot]