cli icon indicating copy to clipboard operation
cli copied to clipboard

[Bug]: Invalid schema: class is invalid when adding special characters (Tailwind)

Open adrienpicard opened this issue 2 years ago • 6 comments

Please confirm that you have:

  • [X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • [X] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

Theme

Expected behavior

Re-opening this 2-years old issue that sadly has been marked as closed.

The following schema is valid and file should sync.

{% schema %}
{
  "name": "Hello",
  "class": "w-full md:w-1/2",
  "settings": [
  ]
}
{% endschema %}

Actual behavior

Getting the following error: Invalid schema: class is invalid

File doesn't sync.

Verbose output

Invalid schema: class is invalid

Reproduction steps

  1. Add TailwindCSS class with special character (e.g. colon) to "class" section schema.
  2. Run shopify theme dev

Operating System

MacOS

Shopify CLI version (check your project's package.json if you're not sure)

3.52.0

Shell

No response

Node version (run node -v if you're not sure)

No response

What language and version are you using in your application?

No response

adrienpicard avatar Dec 09 '23 12:12 adrienpicard

Still present with shopify/shopify-cli 3.53

adrienpicard avatar Jan 15 '24 17:01 adrienpicard

Still present running @shopify/cli/3.56.2 darwin-arm64 node-v21.6.2

adrienpicard avatar Feb 22 '24 11:02 adrienpicard

Running into this as well

mattvague avatar Mar 06 '24 23:03 mattvague

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

github-actions[bot] avatar Apr 18 '24 03:04 github-actions[bot]

Still relevant using @shopify/cli/3.59.0 darwin-arm64 node-v21.7.3

adrienpicard avatar Apr 18 '24 08:04 adrienpicard

Still experiencing this using @shopify/cli/3.59.1 wsl-x64 node-v18.14.2

hcmlopes avatar Apr 29 '24 19:04 hcmlopes

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

github-actions[bot] avatar Jun 11 '24 03:06 github-actions[bot]

Still relevant using @shopify/cli/3.60.1 darwin-arm64 node-v22.1.0

adrienpicard avatar Jun 11 '24 09:06 adrienpicard

Hi @adrienpicard! Thanks for reporting this issue, the fix for this problem actually won’t live on Shopify CLI (see this comment on the previous issue about the same error happening in the code editor), so we’ve forwarded your case to the proper team internally, but we’re closing this issue here. Thanks for sharing this scenario and stay tuned on https://shopify.dev/changelog to get new updates about this

lukeh-shopify avatar Jun 11 '24 23:06 lukeh-shopify