cli icon indicating copy to clipboard operation
cli copied to clipboard

[Bug]: theme translations lost when pushing theme with Shopify GitHub integration

Open MaxDesignFR opened this issue 1 year ago • 9 comments

Please confirm that you have:

  • [X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • [X] Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

Theme

Expected behavior

Theme translations should be preserved.

Actual behavior

Theme translations are lost. It seems translations and Shopify github integration can't coexist right now. There was a similar issue: https://github.com/Shopify/cli/issues/1562 which seems to show we can manually duplicate a translated theme in Shopify backoffice to preserve the "translation link", and then push changes to that duplicated theme (works, but still not ideal and confusing).

But this is incompatible with github workflow which uploads a new theme every time we may need to add a new branch. I find this very problematic and haven't found any workaround.

Verbose output

NA

Reproduction steps

  1. Translate theme (such as templates) in Shopify Translate & Adapt
  2. shopify theme pull to work locally
  3. Publish the local theme to a git repository
  4. Add theme to store with "Connect from GitHub"

Operating System

Windows 11

Shopify CLI version (check your project's package.json if you're not sure)

3.49.4

Shell

No response

Node version (run node -v if you're not sure)

No response

What language and version are you using in your application?

No response

MaxDesignFR avatar Dec 04 '23 10:12 MaxDesignFR