Shopify
[Bug]: theme translations lost when pushing theme with Shopify GitHub integration
Please confirm that you have:
- [X] Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
- [X] Reproduced the issue in the latest CLI version.
In which of these areas are you experiencing a problem?
Theme
Expected behavior
Theme translations should be preserved.
Actual behavior
Theme translations are lost. It seems translations and Shopify github integration can't coexist right now. There was a similar issue: https://github.com/Shopify/cli/issues/1562 which seems to show we can manually duplicate a translated theme in Shopify backoffice to preserve the "translation link", and then push changes to that duplicated theme (works, but still not ideal and confusing).
But this is incompatible with github workflow which uploads a new theme every time we may need to add a new branch. I find this very problematic and haven't found any workaround.
Verbose output
NA
Reproduction steps
- Translate theme (such as templates) in Shopify Translate & Adapt
shopify theme pullto work locally- Publish the local theme to a git repository
- Add theme to store with "Connect from GitHub"
Operating System
Windows 11
Shopify CLI version (check your project's package.json if you're not sure)
3.49.4
Shell
No response
Node version (run node -v if you're not sure)
No response
What language and version are you using in your application?
No response
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.
P.S. You can learn more about why we stale issues here.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Same, still relevant!
On Thu, Feb 15, 2024 at 10:42:43, MaxDesign < @.*** > wrote:
Still relevant
— Reply to this email directly, view it on GitHub ( https://github.com/Shopify/cli/issues/3165#issuecomment-1945710413 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/ARQXFIMMXAMFVZ2Q5Z2X34DYTXKBHAVCNFSM6AAAAABAFYGUGGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBVG4YTANBRGM ). You are receiving this because you commented. Message ID: <Shopify/cli/issues/3165/1945710413 @ github. com>
hi folks 👋 thanks for reporting this issue and letting us know it's still relevant. on the CLI themes side we don't work on the domain that requires to fix your issue (either in the Shopify Github Integration or Translate App). i'll raise internally and keep this issue open so you can +1 this matters to you but i have no ETA on when this would be prioritized
if you have other avenues to raise this issue (like via a merchant success manager) please continue to do that as well
actually going to have to close this for CLI housekeeping but again, feel free to keep +1ing this issue while it's closed as it's still relevant 🙏
👋 the team is aware of this issue. in the meantime they shared this workaround to hopefully ease the friction of copying translations via CSV https://community.shopify.com/c/shopify-translate-adapt/why-did-my-theme-update-erase-most-translations/m-p/2016134#M628
@mgmanzella This is still a ongoing issue that creates significant challenges for live stores. Closing a critical issue for "CLI housekeeping" is doesn't make it go away.
👋 hi folks, i understand this is a frustrating issue and we know this is a problem. this issue was closed as won't do because this team can't actually fix this issue (the CLI and the github integration are not the same tooling and are not owned by the same teams). because of that i've locked the issue now as off-topic for the CLI.
when commenting on issues, keep in mind to adhere to our code of conduct, we will continue to remove unproductive comments that don't respect the community or its maintainers. thanks all 🙏