buy-button-js icon indicating copy to clipboard operation
buy-button-js copied to clipboard

[RFC] update carousel index on every carousel change

Open bezin opened this issue 7 years ago • 0 comments

Hi there,

today we tried to implement a carousel pagination (i.e. 1 image of 3 images) in a product component. We tried several workarounds but nothing worked as expected. We found the carouselIndex property on the corresponding view that was set once to 0, but never got updated. This PR fixes this and makes our use case as simply as editing the imgWithCarousel template and adding the variables {{data.carouselIndex}} and {{data.carouselImages.length}}.

Feel free to comment :)

Cheerio

bezin avatar Jun 14 '18 16:06 bezin