browser_sniffer icon indicating copy to clipboard operation
browser_sniffer copied to clipboard

Published 20 hours ago • verified publisher icon Shopify

Add Nexus support (Nexus 5, Nexus 7 & Nexus 10)

Open EsKuel opened this issue 10 years ago • 1 comments

Hi !

Nexus 10 and 7 are missing in patterns file so the gem currently recognise them as handheld device. I also add Nexus 5 in pattern file to add the whole family :)

EsKuel avatar Jun 10 '14 00:06 EsKuel

Hi there! Thanks so much for the PR.

I think browser sniffer is being far too picky about what's a handheld and what's a tablet. Android docs from the distant past talk about it being the presence of "Mobile" defining handhelds, and the lack of it defining tablets: http://android-developers.blogspot.ca/2010/12/android-browser-user-agent-issues.html

carsonb avatar Jul 11 '14 21:07 carsonb

I am closing this since the pull request is so old. Feel free to open up a new pull request if needed.

jeremywrowe avatar Jun 13 '24 11:06 jeremywrowe