Possible eslint rules to consider adding (living document)

[harshithmohan]

• [x] Extend plugin:@typescript-eslint/recommended

  • Causes 3 rule failures in current codebase
  • @typescript-eslint/no-explicit-any -> Self explanatory
  • @typescript-eslint/ban-types -> Prevents usage of Function, () => {} as type, recommends usage of Record
  • @typescript-eslint/no-non-null-asserted-optional-chain -> Need to turn this off, it's stupid.

• [x] @typescript-eslint/array-type -> Force usage of either Array<T> or T[]

• [x] @typescript-eslint/consistent-type-definitions -> Force usage of Type over Interface

• [x] Extend plugin:@typescript-eslint/stylistic-type-checked -> More "styling" rules. eg., Prefer Record over [key: T]: T, prefer ?? over ||, etc. Also includes @typescript-eslint/array-type which we have added before

[hidden4003]

For no-explicit-any rtkq lazy queries need to be typed better somehow I didn't spend time to figure it out so I put any in there.

[hidden4003]

Which one do we want for @typescript-eslint/array-type ?

[harshithmohan]

I would prefer T[] since that is consistent across languages.

[hidden4003]

How well does it work with complex types? Or should we then convert all rtkq request/response types into actual type declarations instead of being inline?

[harshithmohan]

Things like this seem to still work

[harshithmohan]

wait... This is not supposed to be closed. That's why it says "living document". We can add more rules to this same issue if required

[harshithmohan]

@hidden4003 Check if we should extend this also. For more consistency

plugin:@typescript-eslint/stylistic-type-checked -> More "styling" rules. eg., Prefer Record over [key: T]: T, prefer ?? over ||, etc. Also includes @typescript-eslint/array-type which we have added before