AuctionHouse icon indicating copy to clipboard operation
AuctionHouse copied to clipboard

Error when removing goods from the auction house

Open Wayder228 opened this issue 3 years ago • 4 comments

Issue description

Write the issue description here

Steps to reproduce the issue

  1. When removing goods from the auction, the server crashes!

OS and versions

  • PocketMine-MP: 4.2.0
  • Plugin version: Latest + release
  • Server OS: linux

Error/Crash log (If available)

Error: Only arrays and Traversables can be unpacked
File: plugins/AuctionHouse.phar/src/shock95x/auctionhouse/menu/ExpiredMenu
Line: 55
Type: Error

THIS CRASH WAS CAUSED BY A PLUGIN
BAD PLUGIN: AuctionHouse

Code:
[46] 	}
[47] 
[48] 	public function renderListings(): void {
[49]         foreach($this->getListings() as $index => $listing) {
[50] 			$item = clone $listing->getItem();
[51] 
[52] 			$expiredItem = Locale::get($this->player, "expired-item");
[53] 
[54] 			$lore = str_ireplace(["{PRICE}"], [$listing->getPrice(true, Settings::formatPrice())], preg_filter('/^/', TextFormat::RESET, $expiredItem));
[55] 			$lore = Settings::allowLore() ? [...$item->getLore(), ...$lore] : $lore;
[56] 			$item->setLore($lore);
[57] 
[58]             $this->getInventory()->setItem($index, $item);
[59]         }
[60]        	parent::renderListings();
[61] 	}
[62] 
[63] 	public function handle(Player $player, Item $itemClicked, Inventory $inventory, int $slot): bool {
[64] 		Await::f2c(function () use ($player, $slot, $itemClicked, $inventory) {
[65] 			$storage = DataStorage::getInstance();

Wayder228 avatar Apr 25 '22 06:04 Wayder228

When buying from AH or removing i get a black screen

SiahRBLX avatar May 11 '22 17:05 SiahRBLX

При покупке в AH или удалении получаю черный экран

you need invcrashfix this is a plugin, but this plugin has a bug even with this plugin - removal of item.

Wayder228 avatar May 11 '22 17:05 Wayder228

I have... same issue

SiahRBLX avatar May 12 '22 13:05 SiahRBLX

У меня... такая же проблема

Are you a developer?

Wayder228 avatar May 12 '22 20:05 Wayder228