Denis Chenu

Results 401 comments of Denis Chenu

This remove too on some situation `system.db.CDbCommand.query(SELECT * FROM lime_templates t WHERE t.name='skelvanilla' LIMIT 1)` 317 times on 5.X

> I personally think we should rather be moving away from using non OOP code such as static variables etc. This pr will make us depend more on this, we...

> a bunch of the calls come from here https://github.com/LimeSurvey/LimeSurvey/blob/master/application/models/QuestionTemplate.php#L143 the called attributes there are UNUSED ! :) Good catch here, since i have issue too with this question theme...

> by passing Survey object or languages to QuestionAttribute->getQuestionAttributes() as a parameter instead of querying it from inside of the method, it will end up 5-6 of the 130+ survey...

@TonisOrmisson use cache here can really be easy and really improve for big system (with cache system). Even for 1 request by page, if you have 1000 access by minutes,...

> I suggested to Arpad the other day to cache the entire result from createFieldMap() function, in a new Yii cache component. In any case, I would do a proper...

> > You can't : we need to separate ordering part and prefill part (and maybe token). > > For randomized ordering and token attribute prefill? Yes, that makes sense....

@TonisOrmisson maybe create a singleton object ? For public survey usage principally ?

> > @TonisOrmisson maybe create a singleton object ? For public survey usage principally ? > > @Shnoulle I was wondering about this exactly yesterday :) > Currently, I think...