Sergey "Shnatsel" Davidoff

Results 942 comments of Sergey "Shnatsel" Davidoff

I am seeing significantly worse compression ratio compared to libaom for 4:4:4, likely due to this issue. For still AVIF images I am seeing consistently worse SSIM at up to...

> cargo-auditable> perhaps a crate was updated and forgotten to be re-vendored? You're using vendored crates. You need either to re-run `cargo vendor` or build it without `--locked` or both.

I think your sandbox doesn't take into account `rust-audit-info/Cargo.lock` which is deliberately outside the workspace, so it is not covered by the toplevel `Cargo.lock` file, and so your sandbox that...

So all changes to `png` crate necessary for setting limits have been made, and I can go ahead and close this?

Hey! I made it private until it stabilized and until someone who actually needed it to be public came along. Now it should be stable enough to expose through the...

We can hardcode the limit in `cargo audit` for now.

This may be somehow related to the filesystem locks we hold. We acquire two of them: one for the advisory-db folder, the other for the crates.io package cache.

I tried `cargo nextest` that runs each test in its own process and ran into #1314 so the results are inconclusive

I cannot reproduce `lint_advisory_db` hang anymore and it never hung on CI. It seems to be a tests-only issue so I'm willing to let it slide.

I've suppressed the warnings in https://github.com/rustsec/rustsec/pull/1308 but we should probably move the suppressions to Abscissa proc macros