Sergey "Shnatsel" Davidoff

Results 943 comments of Sergey "Shnatsel" Davidoff

Hm, I just did a fresh install on Linux and it works for me. Could you rename `/Users/andrew/.cargo/advisory-db/` to `advisory-db.broken` and try again? It would be also interesting to get...

The tool fundamentally relies on fetching data from crates.io. But you could have it run offline if you fetch a database dump with `cargo supply-chain update` and then run the...

It might be worth splitting the core types into a separate crate and making that 1.0, while keeping some other stuff under less strict stability guarantees. There is a long-standing...

Ah, you are correct! With GenericImageView we have no guarantee that pixels in a row are laid out in memory contiguously. We can however guarantee this about the `SubImage` type....

I don't think `GenericImageView` being *that* abstract makes a whole lot of sense. Per-pixels accesses will always be slow, so building an API solely around them feels rather pointless. I...

Another bottleneck [was pointed out](https://github.com/image-rs/image/issues/986#issuecomment-2427856993) in a trivial 180 rotation function that's currently implemented like this: https://github.com/image-rs/image/blob/25fbd3f24a1f79035d031ef7f9391b3f7ccffb49/src/imageops/affine.rs#L90-L95 We would like to write it like this instead to reduce the amount...

Also [there is a need](https://github.com/image-rs/image/issues/986#issuecomment-2427862733) for exposing rows as slices rather than a simple iterator. It is not necessary for a 180 degree rotation function, but for more complex image...

Could you provide an example where this would be actually useful? What do you need this functionality for?

I see! Yes, an implementation of DoubleEndedIterator would be nice to have, and shouldn't be difficult. A PR for it would be welcome.

I've written the following example code for blur - feel free to include it in the PR under `examples/`: ```rust use std::env; use std::error::Error; use std::path::Path; use std::process; fn main()...