Sergey "Shnatsel" Davidoff
Sergey "Shnatsel" Davidoff
I wonder if the benchmarks in README should be re-run? `crabz` might perform even better now.
Why is implementing `ReadIntoUninit` unsafe? `std::io::Read` provides a way to write to a Vec yet implementing it is totally safe. Reading into `uninit` is exactly as safe as reading into...
Could a 5% performance hit be worth it in exchange for safety in the short term, until the proper solution that requires refactoring actually lands? The reference FLAC implementation already...
Note that starting from Rust 1.32 this can be done safely via [u16::from_le_bytes()](https://doc.rust-lang.org/std/primitive.u16.html#method.from_le_bytes). If you choose to proceed with this PR, please add a TODO to switch to that implementation...
@TimonPost is that something Crossterm could provide? @gyscos is there a list of ncurses-only features? Perhaps Rust backends could implement the missing APIs once they're aware of them.
`ncurses` is a Unix-only library and yet it provides those key combinations, so it must be possible.
Oh yeah, curl and Firefox work fine.
I've also seen 20 "invalid gzip header" errors in the top 1M. Here's the data: [invalid-gzip-header.tar.gz](https://github.com/sbstp/attohttpc/files/5937146/invalid-gzip-header.tar.gz) That does sound like the issues with "deflate" encoding that the article talks about.
I have the same test code implemented for 4 clients and growing in https://github.com/Shnatsel/rust-http-clients-smoke-test, it might come in handy for comparing behavior between clients.
Oh, and I see you've been working on adding it to `safe_arch` and `bytemuck` as well! Amazing! Thank you so much!