Feliz.MaterialUI icon indicating copy to clipboard operation
Feliz.MaterialUI copied to clipboard

Support DataGrid and XGrid

Open bengobeil opened this issue 3 years ago • 3 comments

Hi @cmeeren,

I am looking to add support for DataGrid and XGrid.

Although I am taking a look at it currently and will probably figure it out, any pointers are appreciated.

Thanks, Ben

bengobeil avatar Feb 16 '21 16:02 bengobeil

Currently they are explicitly not supported:

https://github.com/cmeeren/Feliz.MaterialUI/blob/6f97b285b0164d41bf4801d05f1466f73aad5823/src/Feliz.Generator.MaterialUI/ApiParser.fs#L926-L927

IIRC this is because the API was still very unstable and/or poorly documented. I haven't checked if this has changed. Are they in MUI alpha or the core package?

cmeeren avatar Feb 16 '21 17:02 cmeeren

Still in alpha. Just saw this issue: https://github.com/mui-org/material-ui-x/issues/420

I poked them to see if I could track that issues progress.

bengobeil avatar Feb 16 '21 19:02 bengobeil

From experience, components in alpha can change a lot, and often require digging deep into the MUI source code to find out exactly what kind of objects are returned or accepted in callbacks etc.

DataGrid/XGrid are complicated enough that it would add a lot of maintenance burden until they are part of MUI Core. This is a maintenance burden I simply can't afford at the moment. Therefore I made a decision to not support them until they become stable.

You can still generate your own ad-hoc bindings, of course.

cmeeren avatar Feb 17 '21 08:02 cmeeren