Support .Net 6
Pull request checklist
Please check if your PR fulfills the following requirements:
- [x] Tests for the changes have been added (for bug fixes / features)
- [x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
- [ ] Build (
fake buildor.\build.cmd) on local branch was successfulbuild -t NuGetworks
Pull request type
Please check the type of change your PR introduces:
- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [x] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):
What is the current behavior?
Doesn't support .Net 6.
What is the new behavior?
Supports .Net 6
Does this introduce a breaking change?
- [ ] Yes
- [x] No
Other information
I think this should be changed to 2022. The 2019 image on Appveyor does not have .NET 6 and you'd need to install it manually.
https://github.com/Shmew/Fable.SignalR/blob/dab3b002c00cd298d34f6d3c292c735b1fec16ce/appveyor.yml#L3
Hello, @Shmew, are you around? This would be cool to have.
Trying to add Fable.SignalR.AspNetCore (when Giraffe 6 is also used) right now gives me
Paket may still find a valid resolution, but this might take a while.
Conflict detected:
- fable.signalr.aspnetcore 0.11.5 requested package System.Text.Encodings.Web: >= 5.0 < 6.0
- System.Text.Json 6.0.0 requested package System.Text.Encodings.Web: >= 6.0
I actually wonder if it's really necessary to pin versions of those official .NET packages.
@Shmew what's preventing this from being merged? Anything we can help with?
@PierreYvesR thanks for getting this across the line!
I noticed in the paket.dependencies the Net6 group both Saturn and Giraffe need to be updated to their latest versions, if you want them pinned they need to be updated to 0.16.1 and 6.0.0