gorilla icon indicating copy to clipboard operation
gorilla copied to clipboard
verified publisher icon ShishirPatil

RAFT Reverted `raft.py` param names to dash-case

Open cedricvidal opened this issue 1 year ago • 3 comments

Fixes #414

cedricvidal avatar May 09 '24 17:05 cedricvidal

@kaiwen129 fyi

cedricvidal avatar May 09 '24 19:05 cedricvidal

@cedricvidal Should we keep things consistent and change chunk_size and openai_key in the args list to hyphen case as well?

kaiwen129 avatar May 11 '24 11:05 kaiwen129

Yes of course, I did this quickly and missed it

Cedric

On Sat, May 11, 2024 at 4:59 AM Kai Wen @.***> wrote:

@cedricvidal https://github.com/cedricvidal Should we keep things consistent and change chunk_size and openai_key in the args list to hyphen case as well?

— Reply to this email directly, view it on GitHub https://github.com/ShishirPatil/gorilla/pull/420#issuecomment-2105700719, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIGUV37TXMMPVW72BCBJTZBYBZPAVCNFSM6AAAAABHPGSOU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVG4YDANZRHE . You are receiving this because you were mentioned.Message ID: @.***>

cedricvidal avatar May 11 '24 13:05 cedricvidal