gorilla
gorilla copied to clipboard
[BFCL] `underscore_to_dot` naming issue + not properly used
Two main issues with this property underscore_to_dot
- This should really be named
dot_to_underscoresince we are converting dots in function names to underscores. - This property is not fully utilized. For example in
https://github.com/ShishirPatil/gorilla/blob/a11f16d940c508c6dd91fb55493e6a0ed5a21dfb/berkeley-function-call-leaderboard/bfcl_eval/model_handler/utils.py#L68-L83 a manual search through
ModelStyles to decide which models need conversion should instead use this property. If not, there is potential for conflicts. A thorough search through the codebase is recommended to find instances where this property should be used