Shereef Marzouk

Results 25 comments of Shereef Marzouk

@pgrzesik I don't think it's a serverless issue anymore I dived deep into it yesterday and it's CloudFormation not allowing me to use a duplicate value between 2 stages Yes...

I can't try to produce the example today but I will soon and let you know

I don't know what is rtbx, but please let me know if you got an error you need help with ᐧ Sincerely yours, ------------------------------ Shereef Marzouk Software Engineer @ DaySmart...

Sorry for the late reply, if you find [this file](https://github.com/Shereef/RTF-to-HTML-Converter-Class-Library-DLL/blob/master/MyRTF2HTML.sln) after cloning and then navigate in the solution to [this file](https://github.com/Shereef/RTF-to-HTML-Converter-Class-Library-DLL/blob/master/MyRTF2HTML/RTF2HTML.cs) i think you'll get the gist of it

@mikejpeters did you want to add tests for the new uncovered line ?

Can we please just get `--coverageThresholdPercentage=100` for 100% on everything for more fine grained `--coverageThresholdPercentage=100,100,90,80`

I added a duplicate issue #3518 but closed it here are the details: ### Expected Behavior ``` $ npx commitlint --edit ⧗ input: dfds ✖ subject may not be empty...

I was using `18.13.0` as [stated above](https://github.com/conventional-changelog/commitlint/issues/3485#issuecomment-1414517847) The original poster was using 18 too

@marekdedic 1. I removed the `/* istanbul ignore next*/` 2. `npm install 'https://gitpkg.now.sh/marekdedic/istanbuljs/packages/istanbul-lib-instrument?coverage-fix'` 3. npm run test:cov ``` ---------------------------------------------------|---------|----------|---------|---------|------------------- File | % Stmts | % Branch | % Funcs |...

This was a full project in my previous message Here is from the repo I created to replicate this issue: ``` > [email protected] test:cov > jest --coverage PASS src/app.resolver.spec.ts (9.657...