webpush-go icon indicating copy to clipboard operation
webpush-go copied to clipboard

Allow VAPID sub to be an HTTPS URL

Open emersion opened this issue 2 years ago • 4 comments

The RFC says:

The "sub" claim SHOULD include a contact URI for the application server as either a "mailto:" (email) [RFC6068] or an "https:" [RFC2818] URI.

However the library assumes the passed in subscribed is always an e-mail address, without leaving a way to pass an HTTPS URL.

emersion avatar Oct 31 '23 23:10 emersion

Gentle ping, any chance to get this reviewed?

emersion avatar Nov 12 '23 08:11 emersion

Did you have time to have a look at this, @SherClockHolmes?

emersion avatar Dec 09 '23 00:12 emersion

Gentle ping

emersion avatar Jul 08 '24 06:07 emersion