shentu
shentu copied to clipboard
BUG: add shield crisis invariant fix for the upgrade
Closes: # Related: #XXX
Description
To test the invariant being broken,
first start with a v2.2.0 binary.
- Deposit collateral to shield
- Create a pool
- update the pool, with some additional native fees
- upgrade to v2.3.0 and v2.4.0, and finally latest master
- There will be 3 consecutive upgrades
- The chain will halt at the last upgrade since the crisis invariant is broken due to the bug that happened in the original v2.2.0 binary.
For contributor use:
- [ ] Targeted PR against correct branch (see CONTRIBUTING.md)
- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Code follows the module structure standards.
- [ ] Wrote unit and integration tests
- [ ] Updated relevant documentation (
docs/
) or specification (x/<module>/spec/
) - [ ] Added relevant
godoc
comments. - [ ] Added a relevant changelog entry to the
Unreleased
section inCHANGELOG.md
- [ ] Re-reviewed
Files changed
in the Github PR explorer
For admin use:
- [ ] Added appropriate labels to PR (ex.
WIP
,R4R
,docs
, etc) - [ ] Reviewers assigned
- [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]"
This is currently blocked due to the shield mixedcoins removal missing a upgrade store migration.
Since shield will have its own migration I think it's better to do this there.
Codecov Report
Merging #471 (346d607) into master (7b4fa10) will decrease coverage by
0.19%
. The diff coverage is2.56%
.
Additional details and impacted files
@@ Coverage Diff @@
## master #471 +/- ##
==========================================
- Coverage 41.52% 41.33% -0.20%
==========================================
Files 124 124
Lines 11421 11476 +55
==========================================
+ Hits 4743 4744 +1
- Misses 6219 6273 +54
Partials 459 459
Impacted Files | Coverage Δ | |
---|---|---|
app/upgrade_handler.go | 3.14% <0.00%> (-2.33%) |
:arrow_down: |
app/app.go | 86.92% <100.00%> (+0.02%) |
:arrow_up: |