shentu icon indicating copy to clipboard operation
shentu copied to clipboard

Auth: Unit Test for SDK v0.44.3 Upgrade

Open AmanRaj1608 opened this issue 4 years ago • 2 comments

Closes: #332 Related: #XXX

Description


For contributor use:

  • [ ] Targeted PR against correct branch (see CONTRIBUTING.md)
  • [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • [ ] Code follows the module structure standards.
  • [ ] Wrote unit and integration tests
  • [ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • [ ] Added relevant godoc comments.
  • [ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • [ ] Re-reviewed Files changed in the Github PR explorer

For admin use:

  • [ ] Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • [ ] Reviewers assigned
  • [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]"

AmanRaj1608 avatar Jan 05 '22 18:01 AmanRaj1608

Actually this is not the format that we want. Could you look at #368 for the desired format?

yoongbok-lee avatar Jan 11 '22 04:01 yoongbok-lee

Codecov Report

Merging #367 (3fe0c51) into master (65dc8d2) will increase coverage by 0.08%. The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
+ Coverage   40.83%   40.92%   +0.08%     
==========================================
  Files         127      127              
  Lines       11825    11825              
==========================================
+ Hits         4829     4839      +10     
+ Misses       6528     6519       -9     
+ Partials      468      467       -1     
Impacted Files Coverage Δ
x/auth/types/vesting_account.go 67.16% <0.00%> (+14.92%) :arrow_up:

codecov-commenter avatar Jan 30 '22 20:01 codecov-commenter

Probably needs more test cases, but seems good as-is to be merged in for now.

yoongbok-lee avatar Nov 29 '22 13:11 yoongbok-lee