shentu
shentu copied to clipboard
Auth: Unit Test for SDK v0.44.3 Upgrade
Closes: #332 Related: #XXX
Description
For contributor use:
- [ ] Targeted PR against correct branch (see CONTRIBUTING.md)
- [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [ ] Code follows the module structure standards.
- [ ] Wrote unit and integration tests
- [ ] Updated relevant documentation (
docs/) or specification (x/<module>/spec/) - [ ] Added relevant
godoccomments. - [ ] Added a relevant changelog entry to the
Unreleasedsection inCHANGELOG.md - [ ] Re-reviewed
Files changedin the Github PR explorer
For admin use:
- [ ] Added appropriate labels to PR (ex.
WIP,R4R,docs, etc) - [ ] Reviewers assigned
- [ ] Squashed all commits, uses message "Merge pull request #XYZ: [title]"
Actually this is not the format that we want. Could you look at #368 for the desired format?
Codecov Report
Merging #367 (3fe0c51) into master (65dc8d2) will increase coverage by
0.08%. The diff coverage isn/a.
Additional details and impacted files
@@ Coverage Diff @@
## master #367 +/- ##
==========================================
+ Coverage 40.83% 40.92% +0.08%
==========================================
Files 127 127
Lines 11825 11825
==========================================
+ Hits 4829 4839 +10
+ Misses 6528 6519 -9
+ Partials 468 467 -1
| Impacted Files | Coverage Δ | |
|---|---|---|
| x/auth/types/vesting_account.go | 67.16% <0.00%> (+14.92%) |
:arrow_up: |
Probably needs more test cases, but seems good as-is to be merged in for now.