shelf.nu icon indicating copy to clipboard operation
shelf.nu copied to clipboard
verified publisher icon Shelf-nu

Signing templates - rajdip

Open rajdip-b opened this issue 1 year ago • 2 comments

rajdip-b avatar Apr 17 '24 06:04 rajdip-b

hey @rajdip-b . I updated you branch and fixed all the conflicts. I added a bunch of @TODOs and answered your questions in the code. Still quite some stuff to updated but they are all basically the same. I tried to add @TODO everywhere but it might be that I missed something. Here are the general points:

  • update all service functions to properly catch errors. See any service.server file for example
  • You are not using parseData to get form data
  • You are not using getParams to get params

DonKoko avatar Apr 17 '24 09:04 DonKoko

Excited for this release!

carlosvirreira avatar Apr 24 '24 10:04 carlosvirreira