shelf.nu icon indicating copy to clipboard operation
shelf.nu copied to clipboard

[Bug]: 'Includes checked out assets' warning label is not showing

Open jurrejansen opened this issue 1 year ago • 2 comments

Contact Details

[email protected]

What happened?

This came to my attention by a report made by one of our users with a Team subscription (Leonardo Finzi from Laerdal Medical).

If 2 bookings include 1 or more of the same asset(s) and these asset(s) have a Checked out status a warning label should appear on the booking entry in the index. I have tested this and this has stopped working.

BEFORE THE START DATE / TIME OF 2ND BOOKING https://github.com/Shelf-nu/shelf.nu/assets/76112272/fed7152a-9999-4a22-8f65-5ab5d31f8794

AFTER START DATE / TIME OF 2ND BOOKING https://github.com/Shelf-nu/shelf.nu/assets/76112272/fa18c8a7-6df2-4d45-8688-bf33a1069a1a

What is the expected behaviour?

I am not exactly how was working the last time this was working. I think once the Start date / time of the 2nd booking arrived the warning label started showing.

However, if we have the opportunity to also improve while fixing this I would like to suggest my original approach that was described in the scenario.

Screenshot 2024-03-11 at 13 05 40

Additionally, sending a automated mail to the Administrators of the workspace warning them about a booking that is due for Check-out today and still includes Checked out assets.

Not sure about the complexities of this though.

Version

Hosted (app.shelf.nu)

What browsers are you seeing the problem on?

Chrome

Relevant log output

No response

jurrejansen avatar Mar 11 '24 12:03 jurrejansen

@jurrejansen do you have links to the original design for this. I am not sure what the label should be saying on the bookings index.

DonKoko avatar Jun 27 '24 09:06 DonKoko

"Includes checked out assets"

@DonKoko here's the original scenario which tackled this case: https://www.figma.com/design/ykvc0MhPeNLsrJ4tJsKosQ/Shelf-%7C-UX-Scenarios?node-id=1396-161183

jurrejansen avatar Jun 27 '24 11:06 jurrejansen

This has been resolved.

DonKoko avatar Nov 12 '24 16:11 DonKoko