shelf.nu icon indicating copy to clipboard operation
shelf.nu copied to clipboard

[Enhancement]: Cannot use empty SMTP_USER & SMTP_PWD

Open jon91 opened this issue 1 year ago • 1 comments

Contact Details

No response

What happened?

ShelfStackError 👀: SMTP_PWD is not set

What is the expected behaviour?

Allow empty usage of usr/pw as some SMTP relays are authenticated by IP

Version

Self-hosted

What browsers are you seeing the problem on?

Firefox, Chrome, Safari, Microsoft Edge

Relevant log output

No response

jon91 avatar Feb 19 '24 16:02 jon91

hey @jon91. Thanks for opening an issue in our repository.

Currently thats what we have built and we support. We understand that there are many different ways you can auth but thats the approach we have taken so far. That being said, I will re-label your issue as its not a bug, but rather an enhancement request.

If you are interested in having auth working in different way, please feel free to open a PR with your suggestion. You can find the contribution guide here: https://github.com/Shelf-nu/shelf.nu/blob/main/CONTRIBUTING.md

Moreover, I will point you to the file where we initiate our transporter used for sending emails: https://github.com/Shelf-nu/shelf.nu/blob/main/app/emails/transporter.server.ts

Please let us know if you have any other questions.

DonKoko avatar Feb 20 '24 10:02 DonKoko

Closing due to inactivity

DonKoko avatar Jul 04 '24 13:07 DonKoko