shelf.nu icon indicating copy to clipboard operation
shelf.nu copied to clipboard

[Feature request]: Improvement to custody automatic logging on asset page

Open carlosvirreira opened this issue 1 year ago • 10 comments

Contact Details

No response

Is your feature request related to a problem? Please describe?

I have an admin and a user that have similar names. I want to be able to see the role of the user on the automatically logged mutation change.

Describe the solution you'd like

Can we show the user type somehow whenever a name is mentioned?

Screenshot 2024-02-16 at 17 50 45

Describe alternatives you've considered

No response

Additional context

No response

carlosvirreira avatar Feb 16 '24 16:02 carlosvirreira

Thoughts @jurrejansen @DonKoko

carlosvirreira avatar Feb 16 '24 16:02 carlosvirreira

Yes we can. Do we do it just for the person who gave the custody?

DonKoko avatar Feb 19 '24 10:02 DonKoko

Yeah maybe as a quick fix put (admin) behind the name is user is admin or account owner. Can imagine some workspaces mostly have admins which will not look very nice / cluttered.

More long term solution would be the new design in which we can use badge with avatars and perhaps even a little icon on the avatar indicating admins. Screenshot 2024-02-19 at 11 19 26

But I agree with the (admin) behind name as a quick way to address this request

jurrejansen avatar Feb 19 '24 10:02 jurrejansen

Yeah I think both those are kinda temp solutions. We would need to create something more powerful that solves this and many other issues related to identities. Like we also had a request from a user to actually show the email of the person. I think the best solution that is encompassing everything and will make it handle all cases is to create a popover badge for team members. So if you hover a team member anywhere(with some small exceptions) inside shelf you can see some relevant data like their role, email etc.

DonKoko avatar Mar 27 '24 06:03 DonKoko

A little preview of important team member info when hovering would indeed be nice and perhaps more realistic to build in the short term. Not ideal for mobile though.

Eventually we should work towards a dedicated team member page that can (also) be visited by clicking a team members badge.

Screenshot 2024-03-27 at 11 37 30

jurrejansen avatar Mar 27 '24 10:03 jurrejansen

Popovers work on mobile as well, just on tap rather than hover. Here is what we use, maybe you can give it a test: https://www.radix-ui.com/primitives/docs/components/popover

DonKoko avatar Mar 27 '24 10:03 DonKoko

Works pretty well yeah. Just not a fan of the device UI pushing around drop downs / popovers and stuff. But in this particular case we wont have that problem as we wont have fields that trigger the keyboard.

https://github.com/Shelf-nu/shelf.nu/assets/76112272/842d24bc-4456-4a16-a7fc-5080268d3762

I would prioritize improving the front-end of Notes though. https://github.com/Shelf-nu/shelf.nu/issues/721

jurrejansen avatar Mar 27 '24 12:03 jurrejansen

Keep in mind shadcn also has this specific component. I imagine it something like this: https://ui.shadcn.com/docs/components/hover-card

DonKoko avatar Apr 16 '24 08:04 DonKoko

@DonKoko @carlosvirreira any comments?

https://www.figma.com/file/ykvc0MhPeNLsrJ4tJsKosQ/Shelf-%7C-UX-Scenarios?type=design&node-id=4669-30400&mode=design

jurrejansen avatar Apr 16 '24 11:04 jurrejansen

I very much like it - would work great on demos to show also the user type as part of our automatic logging of asset mutations on shelf

carlosvirreira avatar Apr 16 '24 12:04 carlosvirreira