Signed custody

[DonKoko]

We use the signing-templates branch to keep track of everything related to the templates functionality. At the time of creating this PR the branch already has the functionality for creating the templates, however we have 2 remaining issues for it:

• [x] https://github.com/Shelf-nu/shelf.nu/issues/462
• [ ] https://github.com/Shelf-nu/shelf.nu/issues/499
• [ ] https://github.com/Shelf-nu/shelf.nu/issues/461

Pending decisions:

• [ ] what are the limits on custody agreements. We still need to decide and implement it on DB level
• [ ] Assigning custody to an NRM with an agreement that doesn't require signature is kind of weird UX. What should we do?

[rajdip-b]

@DonKoko cool, i'll go through them and start fixing them one by one

[DonKoko]

@rajdip-b okey here is the update:

1. I have updated signing-templates with main. So you need to update your branch with signing-templates
2. I have fixed the conflicts and added a few @TODO comments that need to be addressed before we merge this
3. Run npm run typecheck and you will see a bunch of TS errors. That is because you have some files and routes that dont follow the new route error/response handling. Those routes need to be updated. Here are the docs: https://github.com/Shelf-nu/shelf.nu/blob/main/docs/handling-errors.md

[carlosvirreira]

hi @rajdip-b was the update from Niko helpful?

[DonKoko]

@rajdip-b Updated the PR with main. Considering what you mentioned on discord, that you already fixed the loaders and actions, we will most likely have conflicts again as I had to touch a lot of files that had issues because of the release of Vite. Let me know when you push your changes so I can help with fixing the conflicts.

[DonKoko]

Points that still need to be worked on:

• [ ] rendering the pdf when the user tries to sign it (ive already fetched and added the pdf url in the sign component)
• [ ] checking the overall flow of how the signing works
• [ ] generating a receipt that jurre mentioned

[carlosvirreira]

Hi @DonKoko (cc @rockingrohit9639 )

Where a custodian/user signs custody - we have a success case design. Please see below:

I do notice that, for the case of an admin selecting that all the user/nrm has to do is just 'receive' the template, for this we indeed have no success case. The thing here @DonKoko is that, the close action does nothing. We are not storing any consent or anything like this so it made sense to just leave it as it is. On retrospect, if you click close we could show some sort of a 'thank you' page.

https://www.figma.com/design/ykvc0MhPeNLsrJ4tJsKosQ/Shelf-%7C-UX-Scenarios?node-id=911-31483