shelf.nu icon indicating copy to clipboard operation
shelf.nu copied to clipboard

[Feature request]: Administrator requires a custodian to read and sign a document when assigning long term custody

Open jurrejansen opened this issue 2 years ago • 25 comments

Contact Details

[email protected]

Is your feature request related to a problem? Please describe?

As an IT manager, whenever I check out an asset to an employee. I want to have the option to enhance the 'formality' of the checkout. Recording the date/time/IP address and signature of an employee that received an asset from me would do this. In case this employee leaves the company. We can then rightfully request the return of all the assets that he / she got access and signed off for.

Describe the solution you'd like

Administrator can attach a pre-configured PDF template document when assigning custody. Optionally the administrator can decide if the custodian needs to leave a signature electronically before custody of the asset is officially assigned. We are going to have ~~both non-registered team members and~~registered team members (users) that actually have an account / email. ~~Both can be custodians.~~

~~[WIP] NON-REGISTERED TEAM MEMBERS~~ https://www.figma.com/file/ykvc0MhPeNLsrJ4tJsKosQ/Shelf-%7C-UX-Scenarios?type=design&node-id=534-92886&mode=design

REGISTERED TEAM MEMBERS (USERS) https://www.figma.com/file/ykvc0MhPeNLsrJ4tJsKosQ/Shelf-%7C-UX-Scenarios?type=design&node-id=626-29627&mode=design

Describe alternatives you've considered

No response

Additional context

No response

jurrejansen avatar Oct 17 '23 08:10 jurrejansen

@carlosvirreira @DonKoko Any comments here? Ignore the non-registered team members designs as we discussed to not implement this option when assigning custody to non-registered team members.

jurrejansen avatar Oct 26 '23 12:10 jurrejansen

If we have to ignore 1 flow then strikethrough it.

~~before the text~~

carlosvirreira avatar Oct 26 '23 12:10 carlosvirreira

/bounty 40

carlosvirreira avatar Nov 21 '23 15:11 carlosvirreira

💎 $40 bounty • Shelf

Steps to solve:

  1. Start working: Comment /attempt #461 with your implementation plan
  2. Submit work: Create a pull request including /claim #461 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to Shelf-nu/shelf.nu!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🔴 @feliciien Nov 22, 2023, 7:45:26 PM WIP
🟢 @rajdip-b Dec 19, 2023, 4:41:49 PM #629

algora-pbc[bot] avatar Nov 21 '23 15:11 algora-pbc[bot]

Note for the future bounty attempter. You might see there some styles that are new layout wise. I want to ask you to please ignore them and focus on the new dashboard setting tab and the fields inside of it only.

This bounty is part of a bigger epic (collect signatures for custody assignments).

Any questions about this bounty can be discussed on our Discord: https://discord.gg/nGdu8zHG

carlosvirreira avatar Nov 21 '23 15:11 carlosvirreira

/attempt #461

Options

feliciien avatar Nov 22 '23 19:11 feliciien

Hello when i run npm run setup i have this error message : "Error: P1001: Can't reach database server at db.nxphroyicgnenkxwolrg.supabase.co:5432

Please make sure your database server is running at db.nxphroyicgnenkxwolrg.supabase.co:5432. ERROR: "setup:db" exited with 1."

But I already add the URL database from the official website here https://supabase.com/dashboard/project/nxphroyicgnenkxwolrg/settings/database

feliciien avatar Nov 22 '23 22:11 feliciien

@DonKoko any idea on what could be happening to Feliciien?

carlosvirreira avatar Nov 23 '23 15:11 carlosvirreira

I try to use 'connection string' and i have this new error message Error: P1001: Can't reach database server at aws-0-eu-west-1.pooler.supabase.com:6543

Please make sure your database server is running at aws-0-eu-west-1.pooler.supabase.com:6543. ERROR: "setup:db" exited with 1. my question is where the server is based .

feliciien avatar Nov 23 '23 19:11 feliciien

hey @feliciien . Seems like something is wrong with your .env file values. I remember having a similar issue when I started with supabase. I could help you further but I would need to look at your config. If you want, feel free to write me on discord and I will assist you as much as I can.

DonKoko avatar Nov 24 '23 13:11 DonKoko

can you send me your Discord username, please? @DonKoko

feliciien avatar Nov 24 '23 17:11 feliciien

@feliciien please join our discord server here: https://discord.gg/32pUupC2 and send me a PM. You will see my there, my name is the same. You could also open a discussion in the issue-discussions channel. That way other people can help you as well.

DonKoko avatar Nov 27 '23 08:11 DonKoko

i solve the issues mentioned above now I'm focusing on the new features Screenshot 2023-11-28 at 11 03 26 PM

feliciien avatar Nov 28 '23 23:11 feliciien

Nice progress @feliciien - let's ship!

carlosvirreira avatar Nov 29 '23 10:11 carlosvirreira

Hello, I want to know when I confirm if I have to create a new page for it or if I have to modify the actual page.

https://github.com/Shelf-nu/shelf.nu/assets/116520199/fb404044-46e8-401a-a341-241e7ddf421a

feliciien avatar Nov 30 '23 19:11 feliciien

for follow the Figma design Screenshot 2023-11-30 at 7 41 02 PM

feliciien avatar Nov 30 '23 19:11 feliciien

@jurrejansen can you assist?

carlosvirreira avatar Nov 30 '23 19:11 carlosvirreira

@feliciien for this issue, did you work on the create/edit of the PDF?

carlosvirreira avatar Dec 11 '23 14:12 carlosvirreira

@feliciien This issue is scoped to assigning custody that requires signature. The creation of the templates documents and signing the template document are handled in other issues that are currently being worked on.

#499 Custodian electronically signs template document before receiving custody

https://github.com/Shelf-nu/shelf.nu/issues/462 Administrators can configure PDF template documents used for assigning Custody and Bookings

jurrejansen avatar Dec 11 '23 15:12 jurrejansen

Hello can I have yours discord's username so we can talk ? Diouf

On Mon, 11 Dec 2023 at 15:13 jurrejansen @.***> wrote:

@feliciien https://github.com/feliciien This issue is scoped to assigning custody that requires signature. The creation of the templates documents and signing the template document are handled in other issues that are currently being worked on.

#499 https://github.com/Shelf-nu/shelf.nu/issues/499 Custodian electronically signs template document before receiving custody

#462 https://github.com/Shelf-nu/shelf.nu/issues/462 Administrators can configure PDF template documents used for assigning Custody and Bookings

— Reply to this email directly, view it on GitHub https://github.com/Shelf-nu/shelf.nu/issues/461#issuecomment-1850278784, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3Y7KBZ2LPWCZNX6SR344N3YI4PLLAVCNFSM6AAAAAA6DNTAUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJQGI3TQNZYGQ . You are receiving this because you were mentioned.Message ID: @.***>

feliciien avatar Dec 11 '23 15:12 feliciien

@feliciien yes! jurrejansen

I think i already added you. Also opened a thread on the Shelf discord.

jurrejansen avatar Dec 11 '23 15:12 jurrejansen

/attempt #461

Options

rajdip-b avatar Dec 19 '23 16:12 rajdip-b

[!NOTE] The user @feliciien is already attempting to complete issue #461 and claim the bounty. We recommend checking in on @feliciien's progress, and potentially collaborating, before starting a new solution.

algora-pbc[bot] avatar Dec 19 '23 16:12 algora-pbc[bot]

💡 @rajdip-b submitted a pull request that claims the bounty. You can visit your bounty board to reward.

algora-pbc[bot] avatar Dec 23 '23 05:12 algora-pbc[bot]

  • What happens when signature is not required? I dont see the flow in the designs. Shouldn't we at least send the template via email? @jurrejansen

DonKoko avatar Dec 27 '23 13:12 DonKoko