shelf.nu icon indicating copy to clipboard operation
shelf.nu copied to clipboard

[Feature request]: Fix Double Booking Issue When Extending Reservations

Open carlosvirreira opened this issue 8 months ago • 2 comments

Contact Details

No response

Is your feature request related to a problem? Please describe?

Currently, when a user extends a booking, the system doesn't check for potential conflicts with other users' reservations for the same asset. This creates a situation where two users can have a booking for the same asset during overlapping time periods.

Problem When User A has an asset checked out and requests an extension that gets approved, the system doesn't recognize if User B already has a reservation for that asset during the extended period. This leads to double bookings and conflicts at pickup time.

Describe the solution you'd like

Proposed Solution

  1. Add a conflict check when processing booking extensions:
  • Before allowing an extension, verify if there are any other reservations for the same asset during the proposed extended period

If a conflict exists, either:

  • Prevent the extension completely
  • Show a prominent warning that clearly indicates the conflict and requires confirmation to proceed

User Experience

When attempting to extend a booking, the admin should see a warning message such as: "⚠️ WARNING: This extension conflicts with User B's reservation from [date/time]. Proceeding will create a double booking."

The warning should be visually distinct (color, icon) to ensure it's not overlooked Provide options to either:

Deny the extension Approve with acknowledgment of the conflict


Business Value

  • Prevents scheduling conflicts and double bookings
  • Improves user satisfaction by ensuring reservations are honored
  • Reduces administrative overhead in resolving booking conflicts
  • Maintains the integrity and reliability of the booking system

Additional Context This issue was discovered when User A had an item checked out, requested and received an extension, and then User B arrived to pick up the same item they had previously reserved for that time period.

Describe alternatives you've considered

No response

Additional context

No response

carlosvirreira avatar May 01 '25 14:05 carlosvirreira

The only thing I would add is that it shouldn't matter if the other bookings have a different custodian or the same one. We should in any case warn the user doing the extension as we cannot assume they would know that, even if the custodian is the same person.

DonKoko avatar May 02 '25 11:05 DonKoko

The only thing I would add is that it shouldn't matter if the other bookings have a different custodian or the same one. We should in any case warn the user doing the extension as we cannot assume they would know that, even if the custodian is the same person.

I agree.

carlosvirreira avatar May 02 '25 13:05 carlosvirreira