Articulate icon indicating copy to clipboard operation
Articulate copied to clipboard

Remaining work for 5.0.0 netcore release for Umbraco 9

Open Shazwazza opened this issue 2 years ago • 22 comments

Remaining work to do for 5.0.0 TODO: This list is not complete!

  • [x] Custom routes (see ArticulateRouter)
    • [x] Tags + Categories
    • [x] RSS for Tags/Categories
    • [x] RSS + XSLT
    • [x] Search
    • [x] Markdown editor
    • [x] Authors RSS
    • [x] Meta weblog
    • [x] Meta weblog Manifest
    • [x] Rsd
    • [x] Open search
    • [x] Resetting routes when umbraco content changes
  • [x] App_Plugins/Themes can be shipped but shouldn't be editable
    • [x] For custom themes that are created in the back office, these should be created in the typical /Views/ folder probably under /Views/Articulate. The files in App_Plugins should be readonly.
  • [x] Multi-target .net6 + .net7
  • [x] BlobMl import/export
    • [x] DisqusXmlExport.xml isn't saved (there is a TODO)
    • [x] Exporting and importing with base64 images
  • [x] Changing all media usages over to use new media picker and media gallery
  • [x] Re-implement OutputCache commented out attributes

Known issues

  • [ ] The current documentation is out of date and should be synced with what is supported in v5
  • [ ] a-new Markdown editor for creating posts doesn't properly support images yet
  • [x] UrlHelperExtensions.ArticulateAuthorRssUrl
  • [x] Rendering the Tags or Categories ends up with RenderTagHtmlContentDateName line items, maybe this is only when date formatted slugs are used?
  • [ ] Surface controller forms rendered on virtual nodes (i.e. tags/categories) and using RedirectToCurrentUmbracoPage. Used to be done with VirtualNodeUrlProvider + ArticulateVirtualPage, but ArticulateVirtualPage is not used anymore, so needs testing and potentially fixing.
  • [x] Tags/Categories RSS YSODs
  • [ ] BlobMl importer won't work for variants (known issue before this release)
  • [ ] BlobMl importer won't work for RTE with macros embedded (known issue before this release)
  • [ ] RSS feed listed in source under application/rss+xml is always for the root RSS even when rendering tags/category pages (which have their own RSS feeds) (known issue before this release)

Shazwazza avatar Jan 19 '22 12:01 Shazwazza

Hi Shaz, just checking how this is going. know you've been working on it when you can. :)

michelletopp avatar Apr 24 '22 12:04 michelletopp

Hi @Shazwazza,

I was wondering if you are progressing with the V9 or V10 implementation.

Best regards, Vasilis

vlinakis2 avatar May 24 '22 08:05 vlinakis2

I haven't had much time to look into this, I would love the community to provide some assistance if possible.

Shazwazza avatar May 25 '22 16:05 Shazwazza

@Shazwazza RSS for Tags/Categories in the Router is already done

warrenbuckley avatar Jul 05 '22 14:07 warrenbuckley

@warrenbuckley awesome, have marked above

Shazwazza avatar Jul 05 '22 18:07 Shazwazza

@Shazwazza this also seems to be done already

UrlHelperExtensions.ArticulateAuthorRssUrl

warrenbuckley avatar Jul 06 '22 12:07 warrenbuckley

@Shazwazza Just a few more items that have been fixed by PRs that are not checked off in this list

Tags/Categories RSS YSODs - Fixed in #397

Rendering the Tags or Categories ends up with RenderTagHtmlContentDateName line items, maybe this is only when date formatted slugs are used? - Fixed in #390

warrenbuckley avatar Jul 28 '22 09:07 warrenbuckley

Have a pending PR #403 for

Resetting routes when umbraco content changes

warrenbuckley avatar Jul 28 '22 13:07 warrenbuckley

@Shazwazza Is there a timeline when Articulate will be available for Umbraco 10? Thanks!?

DasMergo avatar Aug 10 '22 07:08 DasMergo

No timeline, this is a community effort right now. Warren has been making great progress but there's still more work to go and then testing and then beta and rtm.

Shazwazza avatar Aug 10 '22 17:08 Shazwazza

Hi @Shazwazza, Now this package, is available for Umbraco V10 or V11?

ssplyuvrajsingh avatar Feb 04 '23 09:02 ssplyuvrajsingh

Hey @Shazwazza Was going to have a look at "Rendering the Tags or Categories ends up with RenderTagHtmlContentDateName line items, maybe this is only when date formatted slugs are used?" but I was wondering if there was any more info about this? I enabled date formated slugs and couldn't see anything obvious to do with tags etc. Thanks.

OwainWilliams avatar Nov 01 '23 21:11 OwainWilliams

@OwainWilliams hrm, sorry it's been a long time, I 'think' this is referring to rendering tags/categories actually outputs the text: "RenderTagHtmlContentDateName" instead of the actual tags/categories. I can't remember if this is when rendering the tags/categories pages (i.e. https://shazwazza.com/categories) or not. There's also potential, that maybe this is fixed. Sorry, i guess this just needs some investigation.

Shazwazza avatar Nov 01 '23 21:11 Shazwazza

@Shazwazza I guess even just investigating the issue and getting it ticked off as fixed is a help?

I'll look at this tomorrow.

OwainWilliams avatar Nov 01 '23 21:11 OwainWilliams

Absolutely :)

Shazwazza avatar Nov 01 '23 21:11 Shazwazza

  • Rendering the Tags or Categories ends up with RenderTagHtmlContentDateName line items, maybe this is only when date formatted slugs are used?

I've had a look around a few places and rendered tags and categories where they weren't already showing (e.g. homepage) and tags and categories render without any issues. I'd say this has been fixed

image

OwainWilliams avatar Nov 02 '23 11:11 OwainWilliams

  • a-new Markdown editor for creating posts doesn't properly support images yet

Not sure what else is expected from the markdown editor but I selected an image from the backoffice and it rendered with no issues on the front end.

image image

OwainWilliams avatar Nov 02 '23 12:11 OwainWilliams

@OwainWilliams the MD editor in question is the front-end /a-new path that is used to create blog posts, see https://github.com/Shazwazza/Articulate/wiki/Creating-a-blog-post#using-markdown-from-your-browser-works-great-with-mobile-phones-too

Shazwazza avatar Nov 02 '23 15:11 Shazwazza

@OwainWilliams ok lets mark the tag/category item as resolved, thanks!

Shazwazza avatar Nov 02 '23 15:11 Shazwazza

@OwainWilliams also for the "BlobMl importer ..." items, we don't need to worry about this since its a known issue in past releases. These should be converted to bugs if they aren't already.

Shazwazza avatar Nov 02 '23 16:11 Shazwazza

@OwainWilliams also for the "BlobMl importer ..." items, we don't need to worry about this since its a known issue in past releases. These should be converted to bugs if they aren't already.

I can check and I'll raise bugs if needed.

OwainWilliams avatar Nov 02 '23 16:11 OwainWilliams

@OwainWilliams I've also added another bullet point above - the Articulate docs are slightly out of date compared to what is available in v5.

Shazwazza avatar Nov 02 '23 16:11 Shazwazza