Shauren

Results 89 comments of Shauren

The way this is implemented in TC is that item creation is fully prevented, only quest counter is incremented

No, the change wasnt made in a PR (but it doesnt unconditionally apply to all quest items), I will need to investigate this later

You are not seeing "line of sight" here. What is happening is that the ranged spell fails so the npc falls back to meleeing

https://github.com/Jaliborc/BagBrother/issues/41

None of these are marked as world only https://github.com/ElunaLuaEngine/Eluna/blob/6d3cdb74e397bf60804846ccedfcbf024b038e64/TrinityCore/GroupMethods.h#L451-L457 https://github.com/ElunaLuaEngine/Eluna/blob/6d3cdb74e397bf60804846ccedfcbf024b038e64/TrinityCore/GroupMethods.h#L476-L477 https://github.com/ElunaLuaEngine/Eluna/blob/6d3cdb74e397bf60804846ccedfcbf024b038e64/TrinityCore/GuildMethods.h#L262-L266 https://github.com/ElunaLuaEngine/Eluna/blob/6d3cdb74e397bf60804846ccedfcbf024b038e64/TrinityCore/GuildMethods.h#L271-L277 https://github.com/ElunaLuaEngine/Eluna/blob/6d3cdb74e397bf60804846ccedfcbf024b038e64/TrinityCore/PlayerMethods.h#L4077-L4078 https://github.com/ElunaLuaEngine/Eluna/blob/6d3cdb74e397bf60804846ccedfcbf024b038e64/TrinityCore/PlayerMethods.h#L4050-L4053 You can obtain a reference to guild/group from player methods https://github.com/ElunaLuaEngine/Eluna/blob/6d3cdb74e397bf60804846ccedfcbf024b038e64/TrinityCore/PlayerMethods.h#L3811-L3812 https://github.com/ElunaLuaEngine/Eluna/blob/6d3cdb74e397bf60804846ccedfcbf024b038e64/TrinityCore/PlayerMethods.h#L3864

Oh I only pointed those out as a way to access a group/guild objects outside of their dedicated group/guild event hooks that run in world thread only

> Also, the unbind/bind methods in player, are these not inherently safe in the map context since they are strictly tied to the player that already exists in the map...

> The approach in [#474 (comment)](https://github.com/ElunaLuaEngine/Eluna/issues/474#issuecomment-2038338535) would work fine for most if not all cases. The only difficulty is with the GetMembers of guild, group and the get players in...