flutter_tindercard icon indicating copy to clipboard operation
flutter_tindercard copied to clipboard

Flutter 2 null safety migration

Open bkayfitz opened this issue 3 years ago • 4 comments

Here are all the changes required to get this great library to run in Flutter 2. Most of these changes were determined from the automated migration tool, but probably still warrants a quick review.

bkayfitz avatar Mar 28 '21 02:03 bkayfitz

Nice work, buddy! I wonder why this PR is not accepted and merged yet. Just guessing...

ralflorent avatar Jul 09 '21 18:07 ralflorent

Hey @ralflorent Thanks for the feedback! Not sure why the PR was not accepted. I'm thinking this package is not really maintained anymore. You can use my fork of this package if you want to run it with Non Nullable Dart.

https://github.com/bkayfitz/flutter_tindercard/tree/null_safety

If there is enough demand I could upload that fork to pub.dev. Though I really would prefer to avoid creating more noise on that site...

brian-kayfitz avatar Jul 09 '21 20:07 brian-kayfitz

Thank you @bkayfitz for writing this. For others needing null safety checks you can use the repo directly like this. Uploading to pub.dev could confuse people between this repo and yours. Even though this repo isn't maintained.

dependencies:
  flutter_tindercard:
    git: https://github.com/bkayfitz/flutter_tindercard.git

5tigerjelly avatar Mar 16 '23 23:03 5tigerjelly

@5tigerjelly Thanks for the feedback. Its been a long time since I made this change (over a year ago) It seems like we should just upload a new version of this package to pub.dev. Which is unfortunate. I would have preferred to not add more clutter that site

brian-kayfitz avatar Mar 20 '23 13:03 brian-kayfitz