AdvancedSharpAdbClient icon indicating copy to clipboard operation
AdvancedSharpAdbClient copied to clipboard

Published 20 hours ago • verified publisher icon SharpAdb

DumpScreen relies on Xml string not containing "ERROR" inside

Open Lyrapuff opened this issue 1 year ago • 0 comments

Describe the bug

If you call DumpScreen(DeviceData device) on AdvancedAdbClient it'll return null if the dumped Xml contains "ERROR" anywhere inside, even if it's just text in an element

Steps to reproduce the bug

  1. On device open anything that contains text "ERROR"
  2. Call DumpScreen
  3. It returns null

Expected behavior

Get an XmlDocument

Screenshots

No response

NuGet package version

2.5.2

.NET Platform

.NET 6

Platform type

Windows

System version

Windows 10

IDE

Other

Additional context

Does this check really have to be like this? Maybe it can be changed to Equals instead of Contains or even simply be removed

Lyrapuff avatar Sep 03 '22 14:09 Lyrapuff