zf1-future icon indicating copy to clipboard operation
zf1-future copied to clipboard

deprecated passing null to strripos and rtrim with php 8.3

Open sirber opened this issue 1 year ago • 4 comments

( ! ) Deprecated: strripos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /app/vendor/shardj/zf1-future/library/Zend/View/Helper/BaseUrl.php on line 110

( ! ) Deprecated: rtrim(): Passing null to parameter #1 ($string) of type string is deprecated in /app/vendor/shardj/zf1-future/library/Zend/View/Helper/BaseUrl.php on line 72

sirber avatar Jun 20 '24 17:06 sirber

I checked the file, and it looks like these issues have been resolved: https://github.com/Shardj/zf1-future/blob/master/library/Zend/View/Helper/BaseUrl.php

When's the last time you ran a composer update?

B3none avatar Aug 03 '24 20:08 B3none

I'm on the latest 1.24 version, still having those issues.

sirber avatar Aug 03 '24 21:08 sirber

I've got it running on 8.3.9 without any problems, can you give me an example snippet of what you're doing and I'll test it on my end.

Update: Ah, looks like the fix is in master, but 1.24.0 doesn’t contain the latest code for that file.

B3none avatar Aug 03 '24 22:08 B3none

A new release should be made public including this PR https://github.com/Shardj/zf1-future/pull/442 for testing ZF1-Future with PHP 8.4.

addison74 avatar Sep 21 '24 16:09 addison74

Related to #450

sirber avatar Oct 15 '24 12:10 sirber

released 1.24.1 with fix

develart-projects avatar Oct 15 '24 16:10 develart-projects