zf1-future icon indicating copy to clipboard operation
zf1-future copied to clipboard

add TLSv1_3

Open jirapetr opened this issue 1 year ago • 1 comments

Please change library/Zend/Mail/Protocol/Smtp.php .. if ($this->_secure == 'tls') { $this->_send('STARTTLS'); $this->_expect(220, 180); if (!stream_socket_enable_crypto( $this->_socket, true, STREAM_CRYPTO_METHOD_TLSv1_2_CLIENT|STREAM_CRYPTO_METHOD_TLSv1_3_CLIENT )) {

jirapetr avatar Jun 19 '24 11:06 jirapetr

You can create a PR to solve the reported problem.

addison74 avatar Sep 21 '24 16:09 addison74

Adding TLS 1.3 totally makes sense, but dropping the other versions (STREAM_CRYPTO_METHOD_TLS_CLIENT|STREAM_CRYPTO_METHOD_TLSv1_1_CLIENT) is a backwards-compatibility break that I would not want.

Please only add TLS 1.3 and don't drop the others. Or make it configurable if needed, with a default that preserves backwards compatibility.

PHPGangsta avatar Oct 08 '24 10:10 PHPGangsta

Possibly a good note, pls open PR for that, I'll merge that, thanks.

develart-projects avatar Oct 08 '24 10:10 develart-projects

@develart-projects - I opened a PR for this request here following @PHPGangsta request.

addison74 avatar Oct 08 '24 10:10 addison74

Closed with https://github.com/Shardj/zf1-future/pull/447?

sreichel avatar Oct 08 '24 22:10 sreichel

released 1.24.1 with fix

develart-projects avatar Oct 15 '24 16:10 develart-projects