zf1-future icon indicating copy to clipboard operation
zf1-future copied to clipboard

Add ForceIndex function to DB Select.php

Open broqit opened this issue 1 year ago • 7 comments

broqit avatar May 18 '23 08:05 broqit

I have included this change in https://github.com/Shardj/zf1-future/pull/364 with change requested to get it into 1.23.0 release.

develart-projects avatar Aug 10 '23 18:08 develart-projects

We have to postpone this, need to find out why tests are failing:

There were 172 errors:

1) Zend_Db_Select_StaticTest::testSelect
Undefined array key "forceindex"

/home/runner/work/zf1-future/zf1-future/library/Zend/Db/Select.php:1424
/home/runner/work/zf1-future/zf1-future/tests/Zend/Db/Select/StaticTest.php:49
/home/runner/work/zf1-future/zf1-future/tests/resources/Runner.php:20
/home/runner/work/zf1-future/zf1-future/tests/Zend/AllTests.php:143
/home/runner/work/zf1-future/zf1-future/tests/Zend/AllTests.php:267

develart-projects avatar Aug 10 '23 18:08 develart-projects

Sorry I don't think add functional to Zend Framework it's good idea. now ZF in maintain phrase (not development phrase ) so with new functional please extends and move it's to personal package.

hungtrinh avatar Aug 11 '23 09:08 hungtrinh

@hungtrinh I mainly agree, but if someone creates update with tests, why to drop it? It can definitely help to someone else. An we are still maintaining minor/major versioning.

develart-projects avatar Aug 11 '23 09:08 develart-projects

So that means, we need to write a manual guide and a gen API doc somewhere to propagate about new functions too.

In case we add new feature X right now in the near future will add features Y,Z, etc.

hungtrinh avatar Aug 11 '23 11:08 hungtrinh

@hungtrinh we can consider autogen. Should be enough, if correctly docbloc-ked :) But we are talking here about modest updates, like adding new connector, or eg. "insert on duplicate update" DB function, what is something really missing in ZF1 and I'm considering to mainline it in the future.

develart-projects avatar Aug 11 '23 11:08 develart-projects

This was discussed back in https://github.com/Shardj/zf1-future/issues/77 and muted, there was a previous full implementation of FORCE/USE/IGNORE index way back when.

tsmgeek avatar Dec 12 '23 23:12 tsmgeek