George
George
Looks like this is coming from [this line](https://github.com/stellar/js-stellar-sdk/blob/master/src/contract/spec.ts#L955) in spec.ts, so assigning this to @willemneal as the author :saluting_face:
Hmm, my main concern around touching crypto period is always around security. I don't see how/why we would be able to trust the ed25519 polyfill. Hashing seems fine, for sure,...
Reposting what I posted in Discord: > Please read the breaking changes in the [v13.0.0 release notes](https://github.com/stellar/js-stellar-sdk/releases/tag/v13.0.0). This is one relevant piece: > >> The `ClientOptions.signTransaction` type has been updated...
@gregemax this is good enough for me! I would consider the issue closed and completed as "can't reproduce" :+1: thank you!
Yo this is absolutely Herculean, you freakin' rock
Ah yeah we def don't want that; I keep forgetting it's only for tests. I'd like to do it for ts files but not in this commit because it'll bork...
@JuanRdBO hopefully very soon! I want to get a couple of bug fixes in: #764 and #763, before releasing :+1:
@JuanRdBO forgot to add them to TypeScript defs :facepalm: fixed in #766! You can still force it via TS though.
This is done in https://github.com/stellar/js-stellar-sdk/pull/1092
What is `address`? It should be an instance of an [`Account`](https://stellar.github.io/js-stellar-sdk/Account.html). It appears to be an instance of `string`, instead.