Shane Murphy
Shane Murphy
> @ShaneMurphy2 I'd be happy to review a PR if you want to work on it! Does trait variant need to be used on both `Serve` and `Stub`? In my...
> For the blanket impl of Stub, you could probably add a fn to Serve that converts it to Stub. Are you thinking a signature like this in `Serve`: ```rust...
I have a WIP branch up here: https://github.com/ShaneMurphy2/tarpc/tree/trait-variant
Thanks for the info!
Any known workarounds?
> > Any known workarounds? > > A quick workaround would be place the `tracer_provider.force_flush()` inside a blocking task. Something like > > ```rust > let handle = tokio::task::spawn_blocking(move ||...
> @TommyCpp Can I just ask for clarification, how does it block the runtime? I thought that since the multi-threaded runtime uses several threads (in your example 10), then the...
Might be nice to include a note in the crate level docs mentioning that.
> This looks like a reasonable change to me. Perfect, that's what I was looking for by putting up an early draft. > Doesn't Serve need to be made a...
I'll get back to this in a day or so, thanks for the review!