Shane Krueger

Change IComplexityAnalyzer.Validate to return ComplexityError(s)

2

I suggest to change `Validate` signature to return `ComplexityError(s)`. _Originally posted by @sungam3r in https://github.com/graphql-dotnet/graphql-dotnet/pull/3172#discussion_r895101599_

Remove IComplexityAnalyzer and move the analysis code within ComplexityValidationRule

1

Reasoning: `IComplexityAnalyzer` is now just a wrapper for `IValidationRule`. There essentially is no difference between the two interfaces. We can still retain the protected member `Analyzed` within the validation rule....

Fix complexity analyzer fragments' calculations

4

I don't understand what's going on here, but it doesn't seem correct. It should just be `3*6` - where 3 is the value of the parent and 6 is the...

DocumentExecuter should return ExecutionResult when Query & Document are null

1

@sungam3r Uhhh....??? I would change this behavior here to return an `ExecutionResult` as @SlavaUtesinov already posted. While your idea is somewhat logical, it seems like a make-work project. Now the...

UnhandledExceptionDelegate.Context can be null

16

If an exception is thrown before the `IExecutionContext` instance is created, for example while building the document, the caught exception is handled by the `UnhandledExceptionDelegate` with a `null` value for...

Apollo Federation help and sample

5

Hi @Shane32 @joemcbride @sungam3r2022 , I created a [Github repo](https://github.com/killjoy2013/graphql.net-in-apollo-federation) and added detailed explanations and steps in README. Please check it out. Structure is like; ```ts D:\DEV\GIT\GRAPHQL.NET-IN-APOLLO-FEDERATION ├───country-subgraph │ └───src...

Change 'double registration' so one registration pulls from the other [Discuss]

13

See https://github.com/graphql-dotnet/graphql-dotnet/pull/2571#discussion_r774757822 ### Sample existing code ```cs builder.Register(serviceLifetime); builder.Register(serviceLifetime); ``` ### Sample alternate code ```cs builder.Register(serviceLifetime); builder.Register(services => services.GetRequiredService(), serviceLifetime); ``` ### Considerations - In the first example, it is...

Add xml comments for all public members

19

I think there should be a simple `` tag for each public member (all CS1591 build warnings). This issue will track progress as additional documentation is added to the project....

Subscription implementation problems

11

## 1. Execution errors are not returned This seems to be a flaw in the design. I see no reason why the subscription support should not return errors generated while...

User exceptions in subscription's IObservable.Subscribe are not handled by the unhandled error delegate

1

When a subscription is executed, Rule 5.2.3.1 ensures that a single root field is requested; not zero and not more than one. The GraphQL DocumentExecuter in conjunction with the SubscriptionExecutionStrategy...