Shane Krueger

Results 854 comments of Shane Krueger

FYI, I am a maintainer and/or contributor for the following open-source projects, each of which utilize Shouldy's approval testing functionality on older frameworks: - https://www.nuget.org/packages/QRCoder - https://www.nuget.org/packages/Shane32.EasyPDF - https://www.nuget.org/packages/GraphQL -...

The test project itself must target a specific framework implementation and cannot target .NET Standard directly. The api approvals don't actually need to run under more than a single framework...

So it can be used with any framework from 2017 onwards without requiring specific compiler support within this project.

GraphQL.NET uses `ShouldMatchApproved` in several places. Those within the main test project run on .NET Core 3.1, 6.0, 7.0 and 8.0, plus .NET Framework 4.8. Those within the Harness test...

@slang25 Thank you. I'd like to mention another option as well: You could include approval support in the base Shoudly library, and refactor Shouldly.Approvals to be optional DiffEngine support, perhaps...

@slang25 close this now that there's very little code left in Shouldly.DiffEngine, or rebase?

Sorry I forgot about this. I can’t remember where we were but I’m glad to pick it up again.

Anyone know where to find postgres SQL documentation for altering generated columns? This [link here](https://www.postgresql.org/docs/current/ddl-generated-columns.html) only mentions adding generated columns. Or with a sample syntax that we know works, I...

Also, do CI checks automatically run here? Do they test all providers? I'm guessing that locally only SQLite runs by default. I could probably configure MS SQL localdb but I'm...

> So, relatively good news, @Shane32 changes only had one failing test so far: > > FluentMigrator.Tests.Unit.Generators.Postgres.PostgresTableTests.CanCreateTableWithMultiColumnPrimaryKeyWithDefaultSchema(STRICT) I fixed the bug and checked all the similar conditions. Also wrapped all...