Shane Krueger

Results 854 comments of Shane Krueger

Maybe a ctor option to the directive to use the custom scalar so it's not breaking by default?

Schema validation should fail to coerce the argument to StringGraphType (see https://github.com/graphql-dotnet/graphql-dotnet/blob/master/src/GraphQL/Types/Directives/Custom/PatternMatchingDirective.cs ). Unless we don't have schema validation for applied directives' arguments. In which case the schema printing code...

With a custom scalar, ParseLiteral can support strings, and ParseValue can support both strings and RegEx instances. The ToAST method can be overridden to provide a string representation of the...

At least, without trying any code, that's my best guess as to what will happen.

Also related for discussion: - renaming other projects' GraphQLBuilderExtensions class names - moving builder extension classes from other projects into `GraphQL` namespace rather than their own namespace.

I like this concept of a fluent API. It works very well to allow the users to utilize intellisense to determine what they can and cannot do. I suggest we...

I don't care for that design. It would make it even harder (if not impossible) to have effective trimming, and it does not abstract all of the details that people...

I'm also fine if it makes sense for some payloads to have a settings class to configure them. For instance: ```cs QRCode.CreateRussianPaymentOrder( new() { Name = "Henry Jones", BankName =...

> Trimming ... use cases I believe trimming is going to become exceedingly important over the next couple years. We have seen the progression of NativeAOT and trimming within .NET...

> Renderer settings can vary quite a bit, and can get to be extensive, as you've noted 😄 . Including the overload `Render(ArtRenderSettings settings)` allows for adding additional settings (properties)...