Shane Krueger
Shane Krueger
> please review, especially TODO note about extensions type I use my own GraphQL client implementation, and it is based on generics; I wouldn't have a dictionary myself. Although the...
> @Shane32 how would you handle a generic extensions type when a user want's to use his own extension in combination with the integrated APQ feature? I don't use this...
Keep in mind that a dictionary works just as well to be fed into this as an anonymous type. Now in my own library, I also support pre-encoded JSON strings...
It still doesn't deserialize directly from the JsonElement. Just deleting `.GetRawText()` would give me the answer I was looking for. That is a relatively new feature, not existing in .NET...
@rose-a If I remember right, this library supports multiple serializers, so while this answer works for me, may not be the best answer here. It's just an idea.
Yeah, no problem. Just FYI, deserializing to `Dictionary` results in the child elements being `JsonElement` instances. So there is no unnecessary deserialization and reserialization of child nodes. And of course...
> I don't have a good recommendation, either. If their rules cannot be excluded from xUnit.net's source, then likely they'll need to stop using our assertion library outright (or perhaps...
I don't know. See: https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3299
It does seem to make sense, or else source generation (such as System.Text.Json AOT support) would likely break compilation for many repositories where the generated files did not match the...
See similar issue: - #48