Shane Krueger

Results 854 comments of Shane Krueger

Looks good. Also look at current sample: https://github.com/graphql-dotnet/graphql-dotnet/blob/master/src/GraphQL/Validation/Rules/PossibleFragmentSpreads.cs versus previous sample here: https://github.com/graphql-dotnet/graphql-dotnet/blob/f364e4f6cb93e9aaa2f0bdf87b0e43f8a27f6f2b/src/GraphQL/Validation/Rules/PossibleFragmentSpreads.cs

`NodeVisitors` replaces `EnterLeaveListener`. And if you don't have more than one match, you can remove it altogether like @joelmandell 's sample. It is not necessary to make the node visitor...

If you configure the schema to use serial execution, none of the data loaders will run in parallel with any other code (or each other). See this link: - https://graphql-dotnet.github.io/docs/getting-started/dependency-injection/#thread-safety-with-scoped-services...

Feel free to provide a PR to update our documentation. All of the docs' source files are here: https://github.com/graphql-dotnet/graphql-dotnet/tree/master/docs2/site/docs

> No concurrent access to a single scoped dependency - serial `IDataLoaderResult` resolution. Provided for by `SerialExecutionStrategy` > Separate scope dependency copy for each dataloader instance - a hook to...

> We also can't use 'root' scope for entire HTTP call, [`IDataLoaderResult` are resolved asynchronously](https://github.com/graphql-dotnet/graphql-dotnet/blob/master/src/GraphQL/Execution/ExecutionStrategy.cs#L515), this call [is not awaited at the execution strategy level](https://github.com/graphql-dotnet/graphql-dotnet/blob/master/src/GraphQL/Execution/ParallelExecutionStrategy.cs#L95) -> concurrent access exception from...

With the changes to GraphQL Parser v7/v8 there is much more depth required than previously - around double most likely. I think we need to consider the error message from...

Perhaps the burden is on the developer to implement per user/ip/time limits, but certainly we should allow some type of hooks so that on a per-connection basis, the available complexity...

Clearly something is not working correctly. If you can provide a copy of the query that failed, we can test it. No need for the schema definitions.