Shane Krueger
Shane Krueger
As for "we break singleton semantics", I don't think this is quite as important as you seem to indicate. In a typical installation, the schema is only pulled by the...
@sungam3r We should decide on this issue: 1. Leave as-is 2. Register twice, causing double disposal 3. Register with wrapper, to prevent double disposal I suggest leaving as-is. Seems like...
See also: - #2887
> Convert `Schema` into `GraphQLDocument` and then use `SDLWriter`. Completed in - #3649
The new subscription implementation wraps any `OnError` events with the unhandled exception handler, as necessary. There is only one situation left: an exception that is thrown during the call to...
No changes are necessary in the server project, as it should be.
Option 2 doesn't work as the place that `Subscribe` is called is within the server.
@sungam3r Should we add scoped validation rule support for v8? I'd leave it as-is, encouraging singleton use. Users can always register it as a scoped service if they need to...
Transient validation rules would also make sense - every request execution would automatically create a new instance of the validation rule, simplifying local storage of validation rule data during execution.
GraphQL.NET now includes test projects for a fully operational schema-first federation, which is tested via CI during every PR's test run. The test includes two separate schemas, fused together via...