Shane Krueger

Results 854 comments of Shane Krueger

Here's what I'm gathering/thinking: Newtonsoft is synchronous instead of asynchronous, and `FileBufferingReadStream` allows to read the whole stream asynchronously, then deserialize the in-memory stream. This could be done easily with...

@sungam3r I suggest we add a readonly property to `IGraphQLSerializer` called `SupportsAsync` -- or two, with one called `SupportsAsyncReads` and the other `SupportsAsyncWrites`. Something like that so that we can...

> It looks a bit weird to add properties like `SupportsAsyncReads` and `SupportsAsyncWrites` whereas `IGraphQLSerializer` already has methods `ReadAsync` and `WriteAsync` 😕 though you thoughts is understandable. Let's decide if...

It looks like this code only serves a single purpose -- to skip authorization checks of the entire AST. I would prefer more robust functionality where one could mark fields...

I have no comments on the code itself. However, my knowledge of GraphQL.Authorization is limited, as I do not use it in my production libraries.

It is also possible that the framework in this PR could support the other feature. In this case, let's do so. It's possible that with very little effort this PR...

Why does this feature target `develop`? There's nothing specific to version 5, is there? I think this should be added to v4 if it is merely an additional authorization rule.

But as it is now, if we wrote a separate `IAuthorizationSkipCondition` which checked if only nodes marked with 'AllowAnonymous` (or similar) were selected, then it would fail if they also...

It would be really neat if the introspection filter could be tied to this code and the authorization library, perhaps as an optional setting, so only authorized fields would be...

> > then it would fail if they also selected introspection fields > > Right because these are independent things. We need a solution here. > > only authorized fields...