Shane Krueger

Results 854 comments of Shane Krueger

Merge with git. Not squash. Not rebase. Not via PR.

Fast forward, but only if possible??? In Visual Studio, if you do a merge, and there are not new commits in both branches (so nothing to actually merge), it "fast...

I think there should be some logic to the default behavior. Perhaps just types and directives. Perhaps all "sortable" members. I feel that 'no sorting' would be a bad choice....

SchemaPrinter won't print comments anymore, correct? Since a `Schema` can't contain comments, and descriptions will be printed as descriptions, not comments.

Typically one would use a DateTimeOffset which gets formatted in a RFC format with the time offset included. However, I think the current version of GraphQL.NET converts the time stamp...

At first glance I like the look of it!

> @joemcbride do you know why I see this changes when running tests locally but in CI they are not present? `/workspaces/graphql-dotnet/src/GraphQL.ApiTests/netstandard20+netstandard21/GraphQL.approved.txt` ![image](https://user-images.githubusercontent.com/2098029/169373309-0c19e636-e7ee-4d96-ab26-97c0cb2f8c61.png) It's because the latest version of Visual...

> I also see these changes which also seems to be VS Code version related I can't help there; I never use VS Code. As far as I know, @sungam3r...

> Schema First is where the `GraphQLAttribute` was first conceived and added, which is heavily used by this PR. Keep in mind that not all of `GraphQLAttribute.Modify` methods get applied...

> I'll review it some time after v7 release. It definetely should be released in v8. Ping @sungam3r - If you have time available now, I suggest focusing it on...