Shane Krueger

Results 854 comments of Shane Krueger

Trying to read the "initial inputs" would be a pain anyway. The input might be a literal and not contained within the variables, or it might be nested within another...

Suggestion as ideal functionality for `GetArgument`: 1. Should return field value if a value was provided to the query, either via a literal, via a variable value, or a variable...

Also: - Should apply to field arguments and directive arguments - Consider removing `defaultValue` method argument. - Consider exposing `TryGetArgument` and `TryGetArgument`

Edit: ignore this comment!! Well, would I would have thought that `SubFields` would include fragments. If we look at `SetSubFieldNodes` we see this code: ```cs var parentType = parent.GetObjectGraphType(context.Schema)!; var...

Actually I think I misread your original question..... as an interface it can't know what fields are returned from fragment spreads of another type ...... ok..... (sorry I don't use...

Well, `CollectFieldsFrom` is protected. So you could create a derived class with a public method that calls `CollectFieldsFrom`. ```cs public static class MyExecutionStrategyHelper { private static MyExecutionStrategy _strategy = new();...

As a side note, none of the included execution strategy implementations override the method, and there's no instance members, so it makes no difference that it's not the execution strategy...

I agree. It would require adding the method to IExecutionStrategy, and the ability to grab the strategy to IResolveFieldContext.

`ExecutionContext` is a rather large object. You could probably gain performance by using `Interlocked.Exchange` to re-use a shared instance if it isn't already in use. Actually being above to measure...